Bug fixes related to electric-powered vehicles#327
Open
oelsart wants to merge 2 commits into
Open
Conversation
- Ensured that electric-powered vehicles can charge and discharge regardless of whether they consume fuel. - Fixed errors that occurred when connectedPower despawned.
- Fixed and tooltip error on refuel gizmo. - Resolved issue where refuel gizmo button fails to trigger ToggleCharging. - Fixed errors within the info card.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found a few bugs related to electric-powered vehicles.
https://gist.github.com/HugsLibRecordKeeper/8dc833082dfc4f8ffb2677b60ef3b273
It won't charge even when connected to power.
--> Changed to perform charging and discharging before the ShouldConsumeNow check.
Errors when the parent of a connected power comp despawns.
--> Changed to check whether connectedPower.PowerNet exists within CompTick. And Charging property is referenced outside of the ticks, so I added a null check to PowerNet.
Errors in the tooltips and information cards for electric vehicles.
--> Corrected the fuel label to
Wdin the gizmo and toElectricityin the info card.--> Changed ToggleAutoRefuel to ToggleSwitch.