sources/channel: Send Closed for SendSender, not only Sender; fix possible race#236
Merged
notgull merged 2 commits intoSmithay:masterfrom Feb 13, 2026
Merged
sources/channel: Send Closed for SendSender, not only Sender; fix possible race#236notgull merged 2 commits intoSmithay:masterfrom
Closed for SendSender, not only Sender; fix possible race#236notgull merged 2 commits intoSmithay:masterfrom
Conversation
ids1024
added a commit
to ids1024/smithay
that referenced
this pull request
Dec 17, 2025
`SyncSender` isn't properly sending `Closed`: Smithay/calloop#236 In any case, using `Sender` seems appropriate if we don't need it to be `Sync`.
ids1024
added a commit
to ids1024/smithay
that referenced
this pull request
Dec 29, 2025
`SyncSender` isn't properly sending `Closed`: Smithay/calloop#236 In any case, using `Sender` seems appropriate if we don't need it to be `Sync`.
Drakulix
pushed a commit
to Smithay/smithay
that referenced
this pull request
Dec 30, 2025
`SyncSender` isn't properly sending `Closed`: Smithay/calloop#236 In any case, using `Sender` seems appropriate if we don't need it to be `Sync`.
Member
|
@ids1024 Can you rebase on master? |
I believe previous there is a theoretically possible race, since the `.ping()` call would have happened before the `mpsc::Sender` was dropped.
Presumably this should behave like `Sender`, but only ping once all clones have been dropped. This should achieve that.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #236 +/- ##
==========================================
+ Coverage 85.45% 86.20% +0.74%
==========================================
Files 14 16 +2
Lines 1815 2000 +185
==========================================
+ Hits 1551 1724 +173
- Misses 264 276 +12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
Rebased, and now passing CI. |
Merged
notgull
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.