Open
Conversation
a1lu
force-pushed
the
bleeding
branch
8 times, most recently
from
a273d58 to
8ff064e
Compare
uses built-in kill command of sh to generate the list of signal names. If sh is not available the signal number is printed
am11
reviewed
Oct 30, 2019
| @@ -0,0 +1,30 @@ | |||
| #!/bin/sh | |||
Contributor
There was a problem hiding this comment.
Maybe we can just implement it in C by simply using #include <signal.h>, without shelling out the introspection. e.g.:
https://github.com/karelzak/util-linux/blob/917f53cf13c36d32c175f80f2074576595830573/lib/signames.c#L55-L132
Contributor
Author
There was a problem hiding this comment.
We could do that if we only support posix signals.
Contributor
Author
There was a problem hiding this comment.
@Snaipe Whats your opinion on this? Posix or the local signals?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
uses built-in kill command of sh to generate the list of signal names. If
sh is not available the signal number is printed
refs #128