Conversation
We need electron builder modify exe after build to replace the default icon of the app.
There was a problem hiding this comment.
Pull request overview
Updates SnapMind’s Windows branding by improving tray icon handling (including theme-aware switching) and adjusting build configuration to better apply the app icon during Windows packaging.
Changes:
- Added Windows tray icon theme adaptation via
nativeTheme(switches between light/dark.icoassets on theme updates). - Updated Windows builder config to enable executable icon/resource editing.
- Minor formatting/style cleanups across a few TS/TSX files and added jest-dom types to the TS config.
Reviewed changes
Copilot reviewed 6 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tsconfig.json | Adds @testing-library/jest-dom types to compiler options. |
| src/services/AIService.ts | Error throw formatting only. |
| src/components/ModelTable.tsx | Fixes handler termination (;) and normalizes JSX attribute quoting/indentation. |
| src/components/Icon.tsx | Normalizes quote style for react-icons/md import. |
| package-lock.json | Lockfile updates (axios + follow-redirects versions). |
| main.ts | Implements Windows tray icon selection + live updates on theme changes. |
| electron/assets/mind_tray_windows_white.ico | New Windows tray icon variant for dark theme. |
| electron/assets/mind-white.svg | Adds a white SVG asset (currently unused). |
| electron/SettingsService.ts | Formatting only. |
| electron-builder-win.json | Enables signAndEditExecutable to apply icon/resource edits during packaging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Related Issue
Closes #19
Type of Change
Checklist