[Custom Storage 1/3] Add defs for custom storage main #459
+981
−122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 22, 2026
Collaborator
mkolodner-sc
left a comment
mkolodner-sc
left a comment
There was a problem hiding this comment.
Thanks Kyle! Generally LGTM, just a few small comments
| } | ||
|
|
||
| // Configuration for GraphStore storage. | ||
| message GraphStoreStorageConfig { |
Collaborator
There was a problem hiding this comment.
Can this be renamed to GraphStore config or GraphStoreStorage config? StoreStorage seems redundant
Collaborator
Author
There was a problem hiding this comment.
This is configuration for the "storage cluster" in graph store mode, I do get that StoreStorage has some duplication though. If we named it GraphStoreConfig I think it should also include the compute (client) config, which we don't plan to do.
We do name everything with Config here so I guess we could go against this but I am not sure that's the right call, this is a config.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope of work done
Add proto definitions for custom storage main for graph store mode.
Where is the documentation for this feature?: N/A
Did you add automated tests or write a test plan?
Updated Changelog.md? NO
Ready for code review?: NO