Skip to content

Expose GiGL env vars in Vertex AI launcher#653

Merged
kmontemayor2-sc merged 2 commits into
mainfrom
kmonte/expose-vertex-ai-gigl-env-vars
May 29, 2026
Merged

Expose GiGL env vars in Vertex AI launcher#653
kmontemayor2-sc merged 2 commits into
mainfrom
kmonte/expose-vertex-ai-gigl-env-vars

Conversation

@kmontemayor2-sc
Copy link
Copy Markdown
Collaborator

As a follow up to #642 we should expose the same vars on vai.

Scope of work done

Where is the documentation for this feature?: N/A

Did you add automated tests or write a test plan?

Updated Changelog.md? NO

Ready for code review?: NO

@kmontemayor2-sc
Copy link
Copy Markdown
Collaborator Author

/all_test

Comment thread gigl/src/common/vertex_ai_launcher.py Outdated
Copy link
Copy Markdown
Collaborator

@mkolodner-sc mkolodner-sc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kmontemayor2-sc kmontemayor2-sc marked this pull request as ready for review May 29, 2026 17:56
@kmontemayor2-sc kmontemayor2-sc added this pull request to the merge queue May 29, 2026
Merged via the queue into main with commit f3e7386 May 29, 2026
7 checks passed
@kmontemayor2-sc kmontemayor2-sc deleted the kmonte/expose-vertex-ai-gigl-env-vars branch May 29, 2026 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants