Property tab completion and Azure Automation removal

Dockerfile

@@ -1,11 +1,27 @@
-FROM mcr.microsoft.com/powershell:latest
+# LTS image
+FROM mcr.microsoft.com/powershell:7.4-alpine-3.20 AS installer
 
-RUN pwsh -Command 'Set-PSRepository PSGallery -InstallationPolicy Trusted; Install-Module ServiceNow -ErrorAction Stop'
+# Opt-out of telemetry
+ENV POWERSHELL_TELEMETRY_OPTOUT=1
+
+# Install the ServiceNow module to a specific path
+# We use -Scope CurrentUser to keep the path predictable for the 'COPY' step later
+RUN pwsh -Command "Install-Module -Name 'ServiceNow' -Force -AllowClobber -Scope CurrentUser"
+
+# -----------------------------------------------------------------------------
 
-ENV SNOW_SERVER=${SNOW_SERVER}
-ENV SNOW_TOKEN=${SNOW_TOKEN}
-ENV SNOW_USER=${SNOW_USER}
-ENV SNOW_PASS=${SNOW_PASS}
+FROM mcr.microsoft.com/powershell:7.4-alpine-3.20
+
+RUN apk add --no-cache icu-libs
+ENV DOTNET_SYSTEM_GLOBALIZATION_INVARIANT=false
 ENV POWERSHELL_TELEMETRY_OPTOUT=1
 
-SHELL ["pwsh"]
+# Copy only the installed module from the builder stage
+COPY --from=installer /root/.local/share/powershell/Modules/ServiceNow /usr/local/share/powershell/Modules/ServiceNow
+
+# Create a non-root user
+RUN adduser -D psworker
+USER psworker
+WORKDIR /home/psworker
+
+ENTRYPOINT ["pwsh"]

Readme.md

@@ -89,12 +89,6 @@ $params = @{
 New-ServiceNowIncident @params
 ```
 
-### Azure Connection Object (Automation Integration Module Support)
-
-The module can use the `Connection` parameter in conjunction with the included `ServiceNow-Automation.json` file for use as an Azure automation integration module.  Details of the process is available at [Authoring Integration Modules for Azure Automation](https://azure.microsoft.com/en-us/blog/authoring-integration-modules-for-azure-automation).
-
-The `Connection` parameter accepts a hashtable object that requires a username, password, and ServiceNowURL.
-
 ## Scope & Contributing
 
 Contributions are gratefully received, so please feel free to submit a pull request with additional features or amendments.

ServiceNow/Private/Get-ServiceNowAuth.ps1

@@ -14,10 +14,6 @@ function Get-ServiceNowAuth {
     [System.Diagnostics.CodeAnalysis.SuppressMessage('PSAvoidUsingConvertToSecureStringWithPlainText', '', Justification = 'requirement of azure automation')]
 
     param (
-        [Parameter()]
-        [Alias('C')]
-        [hashtable] $Connection,
-
         [Parameter()]
         [Alias('N')]
         [string] $Namespace = 'now',
@@ -83,12 +79,12 @@ function Get-ServiceNowAuth {
                     $hashOut.ProxyUseDefaultCredentials = $true
                 }
             }
-        } elseif ( $Connection ) {
-            Write-Verbose 'connection'
-            # issue 248
-            $pair = '{0}:{1}' -f $Connection.Username, $Connection.Password
-            $hashOut.Headers = @{ Authorization = 'Basic ' + [System.Convert]::ToBase64String([System.Text.Encoding]::ASCII.GetBytes($pair)) }
-            $hashOut.Uri = 'https://{0}/api/{1}/v1' -f $Connection.ServiceNowUri, $Namespace
+        # } elseif ( $Connection ) {
+        #     Write-Verbose 'connection'
+        #     # issue 248
+        #     $pair = '{0}:{1}' -f $Connection.Username, $Connection.Password
+        #     $hashOut.Headers = @{ Authorization = 'Basic ' + [System.Convert]::ToBase64String([System.Text.Encoding]::ASCII.GetBytes($pair)) }
+        #     $hashOut.Uri = 'https://{0}/api/{1}/v1' -f $Connection.ServiceNowUri, $Namespace
         } elseif ( $env:SNOW_SERVER ) {
             $hashOut.Uri = 'https://{0}/api/{1}' -f $env:SNOW_SERVER, $Namespace
             if ( $env:SNOW_TOKEN ) {
@@ -101,7 +97,7 @@ function Get-ServiceNowAuth {
                 throw 'A ServiceNow server environment variable has been set, but authentication via SNOW_TOKEN or SNOW_USER/SNOW_PASS was not found'
             }
         } else {
-            throw "You must authenticate by either calling the New-ServiceNowSession cmdlet or passing in an Azure Automation connection object"
+            throw "You must authenticate by calling the New-ServiceNowSession cmdlet"
         }
     }
 

ServiceNow/Private/Invoke-ServiceNowRestMethod.ps1

@@ -69,15 +69,12 @@ function Invoke-ServiceNowRestMethod {
         [Alias('DisplayValues')]
         [string] $DisplayValue = 'true',
 
-        [Parameter()]
-        [hashtable] $Connection,
-
         [Parameter()]
         [hashtable] $ServiceNowSession = $script:ServiceNowSession
     )
 
     # get header/body auth values
-    $params = Get-ServiceNowAuth -C $Connection -S $ServiceNowSession -N $namespace
+    $params = Get-ServiceNowAuth -S $ServiceNowSession -N $namespace
 
     $params.Method = $Method
     $params.ContentType = 'application/json'

ServiceNow/Private/Invoke-TableIdLookup.ps1

@@ -33,11 +33,6 @@ function Invoke-TableIdLookup {
         [Alias('AS')]
         [switch] $AsSysId,
 
-        [Parameter(ParameterSetName = 'IdSysId')]
-        [Parameter(ParameterSetName = 'TableIdSysId')]
-        [Alias('C')]
-        [hashtable] $Connection,
-
         [Parameter(ParameterSetName = 'IdSysId')]
         [Parameter(ParameterSetName = 'TableIdSysId')]
         [Alias('S')]
@@ -85,7 +80,7 @@ function Invoke-TableIdLookup {
                     Table             = $thisTable.Name
                     Filter            = @('number', '-eq', $ID)
                     Property          = 'sys_class_name', 'sys_id', 'number'
-                    Connection        = $Connection
+
                     ServiceNowSession = $ServiceNowSession
                 }
 

ServiceNow/Public/Add-ServiceNowAttachment.ps1

@@ -26,9 +26,6 @@ Function Add-ServiceNowAttachment {
     .PARAMETER PassThru
     Return the newly created attachment details
 
-    .PARAMETER Connection
-    Azure Automation Connection object containing username, password, and URL for the ServiceNow instance
-
     .PARAMETER ServiceNowSession
     ServiceNow session created by New-ServiceNowSession.  Will default to script-level variable $ServiceNowSession.
 
@@ -104,23 +101,20 @@ Function Add-ServiceNowAttachment {
         [Parameter()]
         [switch] $PassThru,
 
-        [Parameter()]
-        [Hashtable] $Connection,
-
         [Parameter()]
         [hashtable] $ServiceNowSession = $script:ServiceNowSession
     )
 
     begin {
-        $auth = Get-ServiceNowAuth -C $Connection -S $ServiceNowSession
+        $auth = Get-ServiceNowAuth -S $ServiceNowSession
         $params = $auth
         $params.UseBasicParsing = $true
         $params.Method = 'POST'
     }
 
     process	{
 
-        $thisTable, $thisID = Invoke-TableIdLookup -T $Table -I $ID -AsSysId -C $Connection -S $ServiceNowSession
+        $thisTable, $thisID = Invoke-TableIdLookup -T $Table -I $ID -AsSysId -S $ServiceNowSession
 
         foreach ($thisFile in $File) {
 

ServiceNow/Public/Export-ServiceNowAttachment.ps1

@@ -92,15 +92,12 @@ Function Export-ServiceNowAttachment {
         [Parameter(ParameterSetName = 'ToPipeline', Mandatory)]
         [switch] $AsValue,
 
-        [Parameter()]
-        [Hashtable] $Connection,
-
         [Parameter()]
         [hashtable] $ServiceNowSession = $script:ServiceNowSession
     )
 
     begin {
-        $authParams = Get-ServiceNowAuth -C $Connection -S $ServiceNowSession
+        $authParams = Get-ServiceNowAuth -S $ServiceNowSession
     }
 
     process	{

ServiceNow/Public/Get-ServiceNowAttachment.ps1

@@ -33,9 +33,6 @@ Function Get-ServiceNowAttachment {
     Array or multidimensional array of fields to sort on.
     Each array should be of the format @(field, asc/desc).
 
-    .PARAMETER Connection
-    Azure Automation Connection object containing username, password, and URL for the ServiceNow instance
-
     .PARAMETER ServiceNowSession
     ServiceNow session created by New-ServiceNowSession.  Will default to script-level variable $ServiceNowSession.
 
@@ -91,9 +88,6 @@ Function Get-ServiceNowAttachment {
         [ValidateNotNullOrEmpty()]
         [object[]] $Sort,
 
-        [Parameter()]
-        [Hashtable] $Connection,
-
         [Parameter()]
         [hashtable] $ServiceNowSession = $script:ServiceNowSession
     )
@@ -104,14 +98,13 @@ Function Get-ServiceNowAttachment {
             First             = $PSCmdlet.PagingParameters.First
             Skip              = $PSCmdlet.PagingParameters.Skip
             IncludeTotalCount = $PSCmdlet.PagingParameters.IncludeTotalCount
-            Connection        = $Connection
             ServiceNowSession = $ServiceNowSession
         }
     }
 
     process	{
 
-        $thisTable, $thisID = Invoke-TableIdLookup -T $Table -I $ID -AsSysId -C $Connection -S $ServiceNowSession
+        $thisTable, $thisID = Invoke-TableIdLookup -T $Table -I $ID -AsSysId -S $ServiceNowSession
 
         $params.Filter = @('table_name', '-eq', $thisTable.Name), 'and', @('table_sys_id', '-eq', $thisID)
 

ServiceNow/Public/Get-ServiceNowRecord.ps1

@@ -60,9 +60,6 @@
     Only valid when the Property parameter is set to 1 item.
     Helpful when retrieving sys_id for example.
 
-.PARAMETER Connection
-    Azure Automation Connection object containing username, password, and URL for the ServiceNow instance
-
 .PARAMETER ServiceNowSession
     ServiceNow session created by New-ServiceNowSession.  Will default to script-level variable $ServiceNowSession.
 
@@ -233,9 +230,6 @@ function Get-ServiceNowRecord {
         [Parameter()]
         [switch] $AsValue,
 
-        [Parameter()]
-        [hashtable] $Connection,
-
         [Parameter()]
         [hashtable] $ServiceNowSession = $script:ServiceNowSession
     )
@@ -253,7 +247,6 @@ function Get-ServiceNowRecord {
             First             = $PSCmdlet.PagingParameters.First
             Skip              = $PSCmdlet.PagingParameters.Skip
             IncludeTotalCount = $PSCmdlet.PagingParameters.IncludeTotalCount
-            Connection        = $Connection
             ServiceNowSession = $ServiceNowSession
         }
 
@@ -332,7 +325,7 @@ function Get-ServiceNowRecord {
             $thisParams.UriLeaf = '/attachment'
         }
 
-        [array]$result = Invoke-ServiceNowRestMethod @thisParams
+        [array]$result = Invoke-ServiceNowRestMethoduest @thisParams
 
         if ( -not $result ) {
             return
@@ -395,7 +388,7 @@ function Get-ServiceNowRecord {
                                $newVar.Value = $refValue
                            }
                    }
-                        
+
                     }
 
                     if ( $var.'sc_item_option.item_option_new.name' ) {

ServiceNow/Public/Invoke-ServiceNowGraphQL.ps1

@@ -26,9 +26,6 @@
 .PARAMETER Raw
     Provide the server response as is instead of parsing out the application, schema, and service names.
 
-.PARAMETER Connection
-    Azure Automation Connection object containing username, password, and URL for the ServiceNow instance
-
 .PARAMETER ServiceNowSession
     ServiceNow session created by New-ServiceNowSession.  Will default to script-level variable $ServiceNowSession.
 
@@ -68,9 +65,6 @@ function Invoke-ServiceNowGraphQL {
         [Parameter()]
         [switch] $Raw,
 
-        [Parameter()]
-        [hashtable] $Connection,
-
         [Parameter()]
         [hashtable] $ServiceNowSession = $script:ServiceNowSession
     )
@@ -85,7 +79,7 @@ function Invoke-ServiceNowGraphQL {
             $fullQuery = ('{0} {{ {1} {{ {2} {{ {3} }}}}}}' -f $Operation, $Application, $Schema, $Query)
         }
 
-        $params = Get-ServiceNowAuth -C $Connection -S $ServiceNowSession
+        $params = Get-ServiceNowAuth -S $ServiceNowSession
 
         $params.Method = 'Post'
         $params.ContentType = 'application/json'

ServiceNow/Public/New-ServiceNowChangeRequest.ps1

@@ -41,9 +41,6 @@
 .PARAMETER ServiceNowSession
     ServiceNow session created by New-ServiceNowSession.  Will default to script-level variable $ServiceNowSession.
 
-.PARAMETER Connection
-    Azure Automation Connection object containing username, password, and URL for the ServiceNow instance
-
 .PARAMETER PassThru
     If provided, the new record will be returned
 
@@ -112,9 +109,6 @@ function New-ServiceNowChangeRequest {
         [Alias('CustomFields', 'InputData')]
         [hashtable] $CustomField,
 
-        [Parameter()]
-        [Hashtable] $Connection,
-
         [Parameter()]
         [hashtable] $ServiceNowSession = $script:ServiceNowSession,
 
@@ -159,7 +153,6 @@ function New-ServiceNowChangeRequest {
         $params = @{
             Table             = 'change_request'
             Values            = $values
-            Connection        = $Connection
             ServiceNowSession = $ServiceNowSession
             PassThru          = $true
         }

ServiceNow/Public/New-ServiceNowChangeTask.ps1

@@ -24,9 +24,6 @@ function New-ServiceNowChangeTask {
     .PARAMETER CustomField
         Other key/value pairs to create the task which are not one of the existing parameters
 
-    .PARAMETER Connection
-        Azure Automation Connection object containing username, password, and URL for the ServiceNow instance
-
     .PARAMETER PassThru
         Return the newly created item details
 
@@ -63,9 +60,6 @@ function New-ServiceNowChangeTask {
         [Parameter()]
         [hashtable] $CustomField,
 
-        [Parameter()]
-        [Hashtable] $Connection,
-
         [Parameter()]
         [hashtable] $ServiceNowSession = $script:ServiceNowSession,
 
@@ -114,12 +108,11 @@ function New-ServiceNowChangeTask {
             Method            = 'Post'
             Table             = 'change_task'
             Values            = $createValues
-            Connection        = $Connection
             ServiceNowSession = $ServiceNowSession
         }
 
         If ( $PSCmdlet.ShouldProcess($ShortDescription, 'Create new change task') ) {
-            $response = Invoke-ServiceNowRestMethod @params
+            $response = Invoke-ServiceNowRestMethoduest @params
             If ( $PassThru ) {
                 $response.PSObject.TypeNames.Insert(0, "ServiceNow.ChangeTask")
                 $response

ServiceNow/Public/New-ServiceNowConfigurationItem.ps1

@@ -23,9 +23,6 @@
 .PARAMETER PassThru
     Return the newly created CI
 
-.PARAMETER Connection
-    Azure Automation Connection object containing username, password, and URL for the ServiceNow instance
-
 .PARAMETER ServiceNowSession
     ServiceNow session created by New-ServiceNowSession.  Will default to script-level variable $ServiceNowSession.
 
@@ -39,7 +36,7 @@
 #>
 function New-ServiceNowConfigurationItem {
 
-    [CmdletBinding(DefaultParameterSetName = 'Session', SupportsShouldProcess)]
+    [CmdletBinding(SupportsShouldProcess)]
 
     Param(
 
@@ -61,11 +58,7 @@ function New-ServiceNowConfigurationItem {
         [Parameter()]
         [switch] $PassThru,
 
-        [Parameter(ParameterSetName = 'UseConnectionObject', Mandatory)]
-        [ValidateNotNullOrEmpty()]
-        [Hashtable] $Connection,
-
-        [Parameter(ParameterSetName = 'Session')]
+        [Parameter()]
         [ValidateNotNullOrEmpty()]
         [hashtable] $ServiceNowSession = $script:ServiceNowSession
     )
@@ -109,13 +102,7 @@ function New-ServiceNowConfigurationItem {
             Table    = 'cmdb_ci'
             Values   = $TableEntryValues
             PassThru = $true
-        }
-
-        if ($ServiceNowSession) {
-            $params.ServiceNowSession = $ServiceNowSession
-        }
-        else {
-            $params.Connection = $Connection
+            ServiceNowSession = $ServiceNowSession
         }
 
         If ( $PSCmdlet.ShouldProcess($Name, 'Create new configuration item') ) {