Feature/53585 Migrate cookie message#187
Open
jszczech wants to merge 30 commits into
Open
Conversation
added 7 commits
May 20, 2019 14:20
|
This pull request is automatically deployed with Now. Latest deployment for this branch: https://alpaca-ui-git-feature-53585.snowdog1.now.sh |
Aekal
requested changes
May 21, 2019
Member
Aekal
left a comment
Aekal
left a comment
There was a problem hiding this comment.
- In
CookieMessage.jsline 59 we havedocument, but to avoid ssr problems I think we should change it to:
const focusable = this.$root.$el.querySelectorAll('button:not([disabled]), a[href], area[href] input:not([disabled]), select:not([disabled]), textarea:not([disabled]), *[tabindex]:not([tabindex="-1"]), object, embed, *[contenteditable]')
Also this focusable list should be defined after this.isOpen = false, because now cookie itself is the first item to be focused
Aekal
requested changes
May 22, 2019
Aekal
requested changes
May 22, 2019
Aekal
requested changes
May 23, 2019
| background: none; | ||
|
|
||
| .a-cookie-message__close-icon { | ||
| transition: $cookie-message__close-icon-transition; |
Member
There was a problem hiding this comment.
Move this transition to &__close-icon styles, now the transition effect works only in one-way
added 3 commits
May 28, 2019 04:42
# Conflicts: # components/src/03-modules/footer/Footer.js
Contributor
|
sth wrong with line spaces, probably line-height http://prntscr.com/nvu3l7 |
szafran89
suggested changes
May 31, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.