Feature/306#315
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/snowdog/alpaca-ui/3uyt3U1HJMitcJC563DwxJ9XvMVE |
ofrankowska
left a comment
ofrankowska
left a comment
There was a problem hiding this comment.
can you merge changes from update, update colors and add config in the new way?
| @@ -0,0 +1,34 @@ | |||
| <div :class="getClass('input')"> | |||
| <!-- @slot Label (Named slot) --> | |||
| <slot name="label" v-bind="{ label, id }"> | |||
| 'transition-all ease-linear transition-300', | ||
| { | ||
| 'text-xs inline-flex': variant ==='primary' | ||
| }, | ||
| { | ||
| 'flex-shrink-0 mr-4': variant !=='primary' | ||
| }, |
There was a problem hiding this comment.
why are these classes added here instead of config?
| ]" | ||
| > | ||
| <!-- @slot Icon (Named slot) --> | ||
| <slot name="icon" v-bind:variant="variant" /> |
| @@ -0,0 +1,92 @@ | |||
| import { mount, shallowMount } from '@vue/test-utils' | |||
There was a problem hiding this comment.
'shallowMount' is declared but its value is never read
| id: { | ||
| control: { | ||
| type: 'text' | ||
| } | ||
| }, | ||
| label: { | ||
| control: { | ||
| type: 'text' | ||
| } | ||
| }, |
There was a problem hiding this comment.
text controls for props generate automatically so I think this can be removed
| :class="[ | ||
| 'h-12 w-12', | ||
| 'flex items-center justify-center', | ||
| 'absolute right-0', | ||
| variant === 'primary' ? 'top-6' : 'top-0' |
There was a problem hiding this comment.
I think it might be useful to have a variant in config for this. I can see also in designs that we have a seach input with icon on the left. Another slot and variant might be needed.
3 participants
No description provided.