workstation-v0: add GNOME extension/dock validation helper#131
Open
workstation-v0: add GNOME extension/dock validation helper#131
Conversation
- Add gnome/check-gnome-extensions.sh emitting key=value status for gnome_detected, gnome_extensions_cli, gsettings, dash_to_dock, appindicator, favorite_apps, dock_position, dock_autohide, dock_intellihide. Degrades gracefully outside a GNOME session. - Add .github/workflows/workstation-gnome-ext.yml with focused CI smoke: syntax check, key-presence assertions, and stub-based extension state tests (enabled / present-but-not-enabled / missing). - Add tests/workstation-gnome-ext-contract.nix: static Nix contract covering file existence, bash -n, key/UUID grep, and runtime key presence. - Update gnome/README.md with helper documentation and key table. Agent-Logs-Url: https://github.com/SociOS-Linux/source-os/sessions/4cdc1910-e33b-47d2-a594-c5ac40f5204a Co-authored-by: mdheller <21163552+mdheller@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add GNOME dock and extension validation helper
workstation-v0: add GNOME extension/dock validation helper
May 2, 2026
Member
|
Replay review: This PR contains useful GNOME dock/extension validation work, but it is non-mergeable against current Preserve the useful content:
Recommended action: replay this helper into the fresh workstation acceptance cleanup branch, then wire it into the aggregate polish helper using the better #146 pattern. Close this PR as superseded after the fresh replay PR opens. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI and
doctorhad no lightweight way to reason about the Dash-to-Dock / AppIndicator extension lane without a live GNOME session.Changes
gnome/check-gnome-extensions.sh— new standalone helper emittingkey=valuestatus for the extension/dock lane; degrades gracefully whengnome-extensionsorgsettingsare absent.github/workflows/workstation-gnome-ext.yml— focused CI smoke:bash -nsyntax check, all-keys-present assertion in a non-GNOME env, and three stub scenarios exercisingenabled/present/missingextension statestests/workstation-gnome-ext-contract.nix— Nix static contract: file existence,bash -n, key/UUID grep, runtime key-presence check in a headless sandboxgnome/README.md— documents the helper, key table, value semantics, and known gaps (schema absent →unknown)