Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9f69758b83
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| ./scripts/hygiene.sh | ||
|
|
||
| git checkout -b "${BRANCH}" |
There was a problem hiding this comment.
The helper creates the new branch with git checkout -b "${BRANCH}" but does not provide a start point, so it branches from whatever commit the user is currently on. If someone runs this while checked out to a stale topic branch (or any non-main commit), the resulting PR against main will include unrelated commits and can corrupt the intended review scope.
Useful? React with 👍 / 👎.
| git push -u origin "${BRANCH}" | ||
|
|
||
| gh pr create --repo SocioProphet/agentplane --base main --head "${BRANCH}" --title "${MSG}" --body "${MSG}" |
There was a problem hiding this comment.
This script pushes the branch to origin and then opens the PR against a fixed SocioProphet/agentplane repo, which breaks fork-based workflows: when origin is a fork, ${BRANCH} exists only in the fork but gh pr create --repo SocioProphet/agentplane --head "${BRANCH}" tries to resolve that branch in the upstream repo. In that common setup, PR creation fails after the push.
Useful? React with 👍 / 👎.
mdheller
force-pushed
the
workflow/pr-helper
branch
from
be3054b to
9eb68f4
Compare
1 participant
Add scripts/pr.sh for PR-based development under protected main.