Open
Conversation
Author
|
@juriansluiman @jurreantonisse Any update on this? |
|
Hello Thomas, Sorry I'm not able to review this PR. Kind regards |
|
@juriansluiman ping |
|
@jurreantonisse do you have contact with @juriansluiman ? |
snapshotpl
reviewed
Nov 29, 2016
| "container-interop/container-interop": "^1.0" | ||
| }, | ||
| "require-dev": { | ||
| "doctrine/doctrine-orm-module": "~0.9 || ^1.0" |
| protected function getCaches() | ||
| { | ||
| $config = $this->getServiceLocator()->get('Config'); | ||
| $config = $this->container->get('config'); |
There was a problem hiding this comment.
Why not to inject this config into controller?
Author
There was a problem hiding this comment.
@snapshotpl This PR is not a completely refactor, we could do it later in a separate PR, after that this PR will be merged.
|
@juriansluiman ping again... |
|
@juriansluiman ping! |
|
@juriansluiman ping |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated dependencies to support zf2 and zf3 components.
Changed prompt from Select to Number to select cache. This fix the problem when there are more than 9 cache defined.