chore(native): C ABI versioning rule + bump 0.5.0 → 0.6.0#1224
Merged
Conversation
Add src/native/collector/AGENTS.md: the C ABI version (HSM_COLLECTOR_VERSION_*) must bump MINOR for any added/changed exported hsm_* function (MAJOR for breaking), same PR, kept in sync with CMakeLists project VERSION. The product version (HSM_COLLECTOR_PRODUCT_VERSION, the .module/Collector version sensor) is pinned to managed HSMDataCollector.csproj and bumps only at a product release, never native-only. Apply the rule: #1221 added hsm_collector_enable_file_logging (and the recent wave added more functions) without a bump. Bump ABI 0.5.0 -> 0.6.0 and resync CMakeLists (drifted to 0.4.0). Product version stays 3.4.12 (managed parity, no release). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
PR #1224 Review —
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
src/native/collector/AGENTS.md(directory-scoped) documenting the collector's two version numbers:HSM_COLLECTOR_VERSION_*— bumpMINORfor any added/changed exportedhsm_*function (or appended struct field),MAJORfor breaking; same PR; keepCMakeLists.txtproject VERSIONin sync.HSM_COLLECTOR_PRODUCT_VERSION(the.module/Collector versionsensor) — pinned to the managedHSMDataCollector.csproj <Version>; bump only at a DataCollector product release, in lockstep, never native-only.0.5.0 → 0.6.0and resyncCMakeLists.txtproject(HsmCollectorNative VERSION …)(0.4.0 → 0.6.0).Why
The C ABI policy (stated in
hsm_collector.h+docs/native-collector-c-abi.md) requires aMINORbump for every new exported function, but the recent wave — including #1221'shsm_collector_enable_file_logging— added functions since0.5.0(2026-06-27) without bumping.CMakeLists.txthad also drifted (0.4.0vs header0.5.0). OneMINORbump to0.6.0catches up the whole additive batch and resyncs both.HSM_COLLECTOR_PRODUCT_VERSIONstays3.4.12on purpose — it mirrors the managed collector (which had no release); the native logging is parity work, not a product release. To move the.module/Collector versionsensor, both sides bump in lockstep at a real DataCollector release.Notes
src/agent/AGENTS.md(the agent self-update versioning rule, chore(agent): self-update versioning rule + bump 0.5.24 → 0.5.25 #1222).🤖 Generated with Claude Code