Skip to content

fix(collector): C# log quality — quiet graceful-stop discard, HTTP code in single-command failure #1226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lotgon merged 1 commit into from
Jul 3, 2026
Merged

fix(collector): C# log quality — quiet graceful-stop discard, HTTP code in single-command failure #1226

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/collector/HSMDataCollector/Client/HttpsClient/RequestHandlers/CommandHandlers.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ internal override async ValueTask HandleRequestResultAsync(HttpResponseMessage r
var stream = await response.Content.ReadAsStreamAsync().ConfigureAwait(false);
var error = await JsonSerializer.DeserializeAsync<string>(stream, cancellationToken: token).ConfigureAwait(false);

_logger.Error($"Command request for {value.Path} has been faulted. {error}.");
_logger.Error($"Command request for {value.Path} has been faulted. Status Code: {response.StatusCode}, Status Text: {error}.");
}
else
{
Expand Down
4 changes: 3 additions & 1 deletion src/collector/HSMDataCollector/Core/DataProcessor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,8 +392,10 @@ private void EmitOverflowDrops(string queueName, int droppedCount)

private void LogDiscardedItems(int count, string queueName)
{
// Info, not Error: discarding still-buffered values on a graceful shutdown is expected and
// contracted (a stop must not block on a dead/slow transport) — it is not a fault.
if (count > 0)
_logger.Error($"{queueName} queue discarded {count} item(s) during collector shutdown.");
_logger.Info($"{queueName} queue discarded {count} item(s) during collector shutdown.");
}

private void RollbackStartedQueues(bool dataStarted, bool priorityStarted, bool fileStarted, bool commandStarted)
Expand Down
Loading