This repository was archived by the owner on Mar 11, 2023. It is now read-only.
Implement scoring feature.#404
Open
yf-fyf wants to merge 5 commits intoSoftwareFoundationGroupAtKyotoU:masterfrom
Open
Implement scoring feature.#404yf-fyf wants to merge 5 commits intoSoftwareFoundationGroupAtKyotoU:masterfrom
yf-fyf wants to merge 5 commits intoSoftwareFoundationGroupAtKyotoU:masterfrom
Conversation
Contributor
|
config.ru に score.cgi のルーティングが追加されてません |
Contributor
There was a problem hiding this comment.
細かいことですが、一行に詰め込むよりも下の行のように分けてくれた方が読み易い気がしました。
Contributor
There was a problem hiding this comment.
他のコードを見てると e1 ? e1 : e2 のように ? や : の前後スペースを空けてるので統一した方が見やすいかと思います。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
採点機能の実装
内部実装
(今は解けたか解けていないかの二択のみなので，ハッシュデータに使っているのはtrue, falseだけだが，拡張はRuby側でハッシュを拡張するだけで良い)