Skip to content

add lgtm integration - #33

Merged
wholmgren merged 3 commits into
SolarArbiter:masterfrom
wholmgren:lgtm
Mar 1, 2019
Merged

add lgtm integration#33
wholmgren merged 3 commits into
SolarArbiter:masterfrom
wholmgren:lgtm

Conversation

@wholmgren

Copy link
Copy Markdown
Member

https://lgtm.com/projects/g/SolarArbiter/solarforecastarbiter-core/overview/

also enabled pull request review integration in github organization settings

@wholmgren
wholmgren requested a review from lboeman March 1, 2019 18:04

@lboeman lboeman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like LGTM is producing alerts for versioneer, is that to be expected? I don't quite grasp what path_classifiers is doing and a quick look through their documentation doesn't show anything about excluding files.

@wholmgren

Copy link
Copy Markdown
Member Author

Thanks for checking. Looks like their yaml spec has changed since I first did this in pvlib/pvlib-python#561

@wholmgren

Copy link
Copy Markdown
Member Author

@lboeman

lboeman commented Mar 1, 2019

Copy link
Copy Markdown
Member

Thanks for checking. Looks like their yaml spec has changed since I first did this in pvlib/pvlib-python#561

It looks like the .lgtm.yml is written correctly, and the pvlib version isn't suffering from the same issue. The only difference I can see is the lack of newline at the end of the .yml file which perhaps is affecting parsing?

@wholmgren

Copy link
Copy Markdown
Member Author

generated is a valid tag: https://help.semmle.com/lgtm-enterprise/user/help/file-classification.html#built-in-tags

I think LGTM config must be in the head master, not the merge candidate. Tony's not here, so let's merge it and find out!

@wholmgren
wholmgren merged commit 3a508d0 into SolarArbiter:master Mar 1, 2019
@wholmgren
wholmgren deleted the lgtm branch March 1, 2019 20:36
@wholmgren wholmgren added the infrastructure integrations, packaging, etc. label Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

infrastructure integrations, packaging, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants