Use current condensation version and allow for values to be passed down through templates#1
Open
kmcgrath wants to merge 3 commits intoSonalOjha:particle_lambda_changesfrom
Open
Use current condensation version and allow for values to be passed down through templates#1kmcgrath wants to merge 3 commits intoSonalOjha:particle_lambda_changesfrom
kmcgrath wants to merge 3 commits intoSonalOjha:particle_lambda_changesfrom
Conversation
added 3 commits
October 2, 2015 11:52
…ore and passing values down through templates
Owner
|
Changes looks good to me and makes things easier to use. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
assetPath should be passed from here in the template. Using the config file limits the number of lambda functions that can be deployed per project to 1.
The policy for cloudsploit-scans should also live with this project and not the downstream particles-lambda project.
The runtime for this project is always nodejs. Removing the parameter which asks for this value.