Skip to content

RP-949 Update jdx/mise-action to v4 in promote action#243

Closed
jerome-chetelat-sonarsource wants to merge 1 commit intomasterfrom
jc/SC-43043/update-mise-action-to-v4
Closed

RP-949 Update jdx/mise-action to v4 in promote action#243
jerome-chetelat-sonarsource wants to merge 1 commit intomasterfrom
jc/SC-43043/update-mise-action-to-v4

Conversation

@jerome-chetelat-sonarsource
Copy link
Copy Markdown

@jerome-chetelat-sonarsource jerome-chetelat-sonarsource commented Apr 2, 2026

Updating mise-action to v4 to fix failing python 3.13 installation. This version of the action also uses Node.js 24 for the upcomming deprecation of Node.js 20 in GHA runners.

@hashicorp-vault-sonar-prod
Copy link
Copy Markdown

hashicorp-vault-sonar-prod bot commented Apr 2, 2026

RP-949

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 2, 2026

@jerome-chetelat-sonarsource jerome-chetelat-sonarsource marked this pull request as ready for review April 2, 2026 13:11
@jerome-chetelat-sonarsource jerome-chetelat-sonarsource requested a review from a team as a code owner April 2, 2026 13:11
@sonar-review-alpha
Copy link
Copy Markdown

sonar-review-alpha bot commented Apr 2, 2026

Summary

Updates the jdx/mise-action dependency from v3.6.3 to v4.0.1 in the promote action workflow, along with bumping the mise version from 2026.3.7 to 2026.4.0. These updates address Python 3.13 installation failures and prepare for Node.js 20 deprecation in GitHub Actions.

What reviewers should know

This is a straightforward dependency update confined to a single file (promote/action.yml). Key points for review:

  1. File scope: Only promote/action.yml is modified — the promote action's workflow configuration.
  2. Changes: Two version updates on lines 60-61 (the mise-action action reference) and line 63 (the mise version input).
  3. What to verify: Confirm that mise-action v4.0.1 is stable and that the changes don't break the promote action workflow. You may want to check if there are any breaking changes in mise-action v4 or the new mise version (2026.4.0) that could affect this workflow.
  4. Context: The promote action handles artifact promotion via Artifactory and GitHub—these version updates maintain compatibility with current GitHub Actions environments.

  • Generate Walkthrough
  • Generate Diagram

🗣️ Give feedback

Copy link
Copy Markdown

@sonar-review-alpha sonar-review-alpha bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✅

Clean, minimal version bump with no logic changes. No issues found.

🗣️ Give feedback

@matemoln
Copy link
Copy Markdown
Contributor

matemoln commented Apr 2, 2026

Closing this in favor of #232 and #111. Thanks @jerome-chetelat-sonarsource for reporting the issue!

@matemoln matemoln closed this Apr 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants