You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In provision-s3-cache, the action has import mode enabled by default. Since S3 was empty on first run, it fell back to GitHub cache and found test-migration-s3hit (saved with github-content by provision-github-cache), restored that, and then the post-step saved github-content to S3 — overwriting the intended s3-content.
Log confirms:
Cache not found for input keys: refs/heads/master/test-migration-s3hit
Cache hit for: test-migration-s3hit ← GitHub import!
Cache saved with key: refs/heads/master/test-migration-s3hit ← saves github-content to S3
Fix: add import-github-cache: 'false' to the provision-s3-cache step so the GitHub import can't interfere.
Adds import-github-cache: 'false' to the provision-s3-cache test job to disable falling back to GitHub's native cache. This ensures the test actually validates S3 cache behavior instead of potentially hitting GitHub's cache as a fallback, making the test more reliable and focused.
What reviewers should know
The change is a single line in .github/workflows/test-cache-migration-gh2s3.yml (line 48). The parameter prevents the cache action from importing cached data from GitHub's native cache service, forcing the test to exercise only the S3 backend. This is critical for a migration test — without this flag, a cache hit could come from GitHub instead of S3, masking issues in the S3 implementation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![sonar-review-alpha[bot]](https://avatars.githubusercontent.com/in/3025063?s=60&v=4){kind=small}
julien-carsique-sonarsource
deleted the
fix/jcarsique/BUILD-10724-migrationGh2s3Test
branch
Fix https://github.com/SonarSource/gh-action_cache/actions/runs/23498187931/job/68385308447#annotation:4:9
In provision-s3-cache, the action has import mode enabled by default. Since S3 was empty on first run, it fell back to GitHub cache and found test-migration-s3hit (saved with github-content by provision-github-cache), restored that, and then the post-step saved github-content to S3 — overwriting the intended s3-content.
Log confirms:
Fix: add
import-github-cache: 'false'to the provision-s3-cache step so the GitHub import can't interfere.