Skip to content

BUILD-10774: Changes default value of fallback-to-default-branch flag to true#52

Merged
julien-carsique-sonarsource merged 1 commit intomasterfrom
BUILD-10774-set-fallback-to-default-branch-true
Mar 25, 2026
Merged

BUILD-10774: Changes default value of fallback-to-default-branch flag to true#52
julien-carsique-sonarsource merged 1 commit intomasterfrom
BUILD-10774-set-fallback-to-default-branch-true

Conversation

@bwalsh434
Copy link
Copy Markdown
Contributor

What Changed?

  • Changes default value of fallback-to-default-branch flag to true

Test Plan

  • This flag being set to true has already been extensively tested in previous PRs

@bwalsh434 bwalsh434 marked this pull request as ready for review March 24, 2026 19:14
@bwalsh434 bwalsh434 requested a review from a team as a code owner March 24, 2026 19:14
@sonar-review-alpha
Copy link
Copy Markdown

sonar-review-alpha bot commented Mar 24, 2026

Summary

This PR changes the default value of the fallback-to-default-branch input from false to true in the GitHub Action. This means cache lookups will now automatically fall back to the default branch cache when no exact match is found on the current branch (S3 backend only), unless explicitly disabled. The change is reflected in both the action configuration and documentation.

What reviewers should know

The changes are minimal and isolated: (1) action.yml line 37 changes the default, and (2) README.md line 77 updates the documentation table. Verify that both files are consistent with the new default. Since the author notes this behavior has been extensively tested in previous PRs, focus on confirming the change is intentional and complete — no other references to this default need updating.


  • Generate Walkthrough
  • Generate Diagram

🗣️ Give feedback

Copy link
Copy Markdown

@sonar-review-alpha sonar-review-alpha bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conclusion

Clean, minimal change — the default flip is consistent across action.yml and README.md, and the flag's existing semantics and documentation are unchanged.

🗣️ Give feedback

@julien-carsique-sonarsource julien-carsique-sonarsource force-pushed the BUILD-10774-set-fallback-to-default-branch-true branch from 78c8394 to 00fc9a0 Compare March 25, 2026 11:09
@sonarqubecloud
Copy link
Copy Markdown

@sonarqube-cloud-us
Copy link
Copy Markdown

Copy link
Copy Markdown

@sonar-review-alpha sonar-review-alpha bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conclusion

Straightforward default-flip with matching doc update. Both files are consistent. No issues found.

🗣️ Give feedback

@julien-carsique-sonarsource julien-carsique-sonarsource merged commit eaf3a34 into master Mar 25, 2026
20 checks passed
@julien-carsique-sonarsource julien-carsique-sonarsource deleted the BUILD-10774-set-fallback-to-default-branch-true branch March 25, 2026 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants