BUILD-10801: Set S3 as the default backend for all repositories#53
Conversation
bdf92e9 to
fb94ac5
Compare
SummaryChanges the default cache backend from visibility-based (public→GitHub, private→S3) to S3 for all repositories. Public repos now auto-enable GitHub cache import by default ( What reviewers should knowStart in
|
fb94ac5 to
4a8bf00
Compare
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
4a8bf00 to
d76d0be
Compare
SonarQube reviewer guide
|
SonarQube reviewer guide
|
There was a problem hiding this comment.
LGTM! ✅
Clean, focused change. The logic flows correctly across all backend-selection combinations (forced input, env var, auto-detected public, auto-detected private), the new was-github-default signal is properly scoped to the auto-detection branch only, and the test scenario correctly exercises the new code path distinct from the forced-S3 path.




Summary
was-github-defaultoutput from the backend-detection step to identify public repos that previously used GitHub cache by defaultimport-github-cachedefault description, and Migration Mode resolution ordertest-cache-migration-gh2s3.yml: auto-detected S3 on a public repo triggers GitHub import viawas-github-default=true(distinct from thebackend-source=forcedpath in scenario 1)Test plan
CI-covered:
test-auto-public-import-enabled)backend: s3→ migration enabled (test-s3-import-enabled)import-github-cache: falseinput → migration disabled (test-s3-import-disabled)CACHE_IMPORT_GITHUB=falseenv var → migration disabled (test-s3-import-disabled-via-env)test-s3-hit-skips-github-import)backend: githubinput → GitHub backend (test-action.yml)Manual — will be covered after merge, before release, via dogfooding on the dummy repositories:
CACHE_BACKEND=githubenv var → GitHub backend