CLI-180 Test Windows install script [NEW]

[tomshafir-sonarsource]

No description provided.

[hashicorp-vault-sonar-prod]

CLI-180

[sonar-review-alpha]

Summary

Adds Windows support for CLI install script testing and CI/CD. The PR extends the test infrastructure and CI pipeline to validate that both install.sh (Linux) and install.ps1 (Windows) scripts work correctly end-to-end.

Key changes:

• New E2E test suite (install-scripts.test.ts) that validates install scripts on both platforms
• CI pipeline now runs tests on both Linux and Windows via matrix builds
• Extracted platform-agnostic utilities into a new platform.ts module (IS_WINDOWS, buildHomeEnv(), hookScriptName(), hookScriptPath()) to eliminate duplicated platform logic
• Test harness updated for Windows compatibility: file detection by extension, async cleanup with retries (fixes file-locking issues), proper PATH variable handling
• Integration tests refactored to skip Unix-specific shell tests on Windows, use platform-aware naming conventions

What reviewers should know

Start here:

1. Review tests/integration/harness/platform.ts — this is the core abstraction layer extracting platform-specific utilities. Pay special attention to buildHomeEnv() (sets both USERPROFILE and HOME on Windows for Git MSYS2 bash) and hookScriptPath() (handles PowerShell command wrapping).
2. Check the new E2E test in tests/e2e/install-scripts.test.ts — verifies install.ps1 works on Windows with extended timeout (240s for PowerShell cold-start).

Key architectural decisions:

• All Windows-specific path logic, extension handling, and environment setup is centralized in platform.ts to prevent scattered platform checks
• buildHomeEnv() sets both HOME and USERPROFILE on Windows (not just USERPROFILE) because Git for Windows runs hooks in MSYS2 bash, which derives HOME from HOMEDRIVE+HOMEPATH when unset
• File cleanup changed from sync rmSync() to async rm() with retries — Windows holds locks on files longer and the retries prevent spurious failures
• Symlinks changed to file copies on Windows (requires admin/Developer Mode), but only in test setup

What to watch for:

• The CI matrix build in build.yml — verify the conditional steps (libsecret, test:coverage vs test:all, e2e on branches, sonar analysis) run on the correct OS
• Windows-specific test skips use .skipIf(IS_WINDOWS) for Unix-only shell tests (e.g., git-husky script execution)
• File path normalization in test assertions — hookScriptPath() always normalizes to forward slashes for consistency
• PATH variable case sensitivity — explicitly removes Path on Windows to avoid conflicts with PATH
• E2E test cleanup in afterEach() calls removeFromUserPath() to clean up the user's PATH (real system mutation) — verify this runs even if the test fails

Testing considerations:

• E2E tests require real network access (binaries.sonarsource.com) and network connectivity
• PowerShell timeout is 240s vs 120s for shell tests (cold PowerShell startup overhead)
• Integration tests on Windows may take longer due to file locking behavior on cleanup

---

• Generate Walkthrough
• Generate Diagram

🗣️ Give feedback

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues
0 New dependency risks

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[sonar-review-alpha]

LGTM! ✅

🗣️ Give feedback

[kirill-knize-sonarsource]

LGTM! Great work!