Fix PR description including already shipped PRs when using fixedMajorVersion#317
Merged
Songmu merged 2 commits intoSongmu:mainfrom Feb 25, 2026
Merged
Conversation
This was referenced Feb 25, 2026
Merged
Konboi
added a commit
to cloudbees-oss/smart-tests-cli
that referenced
this pull request
Feb 25, 2026
ono-max
pushed a commit
to cloudbees-oss/smart-tests-cli
that referenced
this pull request
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
When
tagpr.fixedMajorVersionis configured (e.g., maintaining v1.x on one branch and v2.x on another), the release PR description incorrectly lists PRs that were already shipped under a different major version line.This happens because
gh2changelogpicks the globally latest tag aspreviousTagfor GitHub'sGenerateReleaseNotesAPI without considering the major version filter. For example, when releasingv1.121.2, it compares againstv2.4.0instead ofv1.121.1, causing all PRs between those two tags to appear in the description.ref: cloudbees-oss/smart-tests-cli#1244 and cloudbees-oss/smart-tests-cli#1245
What
FilteredMajorVersionoption togh2changelogthat filters semver tags by major version before selectingpreviousTagfixedMajorVersionfrom the tagpr config intogh2changelogvia the new option