fix: use null instead of undefined for D1 bind params in media upload#765
Open
fix: use null instead of undefined for D1 bind params in media upload#765
Conversation
…ia upload D1 (Cloudflare's SQLite) throws D1_TYPE_ERROR when binding undefined values. Non-image uploads (PDFs, documents) left width, height, and thumbnailUrl as undefined. Initialize these fields as null from the start so null is carried through the entire flow. Fixes both single and multi-file upload endpoints. Closes #622 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
D1_TYPE_ERRORwhen bindingundefinedvalueswidth,height, andthumbnailUrlasundefinednullfrom the start so null flows through the entire insert without relying on nullish coalescing at bind timeTest plan
.docxor other non-image fileD1_TYPE_ERRORoccursCloses #622
🤖 Generated with Claude Code