fix: replace userDropdown id with class for mobile compatibility#767
Open
fix: replace userDropdown id with class for mobile compatibility#767
Conversation
Using getElementById('userDropdown') breaks when multiple dropdown
elements exist (e.g., desktop sidebar + mobile hamburger menu both
render a user dropdown). Only the first element is found, leaving
the other non-functional.
Switch all templates to use querySelectorAll('.userDropdown') so
every dropdown instance toggles correctly.
Closes #398
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getElementById("userDropdown")only returns the first matching element, breaking the dropdown when both desktop sidebar and mobile menu render oneadmin-layout-v2,admin-layout-catalyst,glass-admin) to usequerySelectorAll(".userDropdown")so every dropdown instance toggles correctlyid="userDropdown"toclass="userDropdown"where neededTest plan
Closes #398
🤖 Generated with Claude Code