Add 'katipSetContext' which doesn't leak#154
Open
jappeace wants to merge 5 commits intoSoostone:masterfrom
Open
Add 'katipSetContext' which doesn't leak#154jappeace wants to merge 5 commits intoSoostone:masterfrom
jappeace wants to merge 5 commits intoSoostone:masterfrom
Conversation
Member
|
Taking a stab at this without running the code (sorry not able to ATM). The way you're looping, aren't you just repeatedly calling |
This comment was marked as outdated.
This comment was marked as outdated.
Author
|
btw those recent changes made this work ^ @MichaelXavier @ozataman |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #153
This introduces an alternative api which allows the following code to run without memory build up.
new katipSetContext:
compared to katipAddContext:
NB, see my reproducer repo for the code that generated these graphs:
https://github.com/jappeace/katip
My initial attempt failed because the map needed to have a strict field (I'm uncertain why).