Open
Conversation
Philogy
reviewed
Aug 31, 2025
Contributor
Philogy
left a comment
Philogy
left a comment
There was a problem hiding this comment.
I don't see any update to tests, how are you testing that this doesn't run into the donate above edge case?
Comment on lines
+174
to
+176
| while start_tick % I24::unchecked_from(self.tick_spacing) != I24::ZERO { | ||
| start_tick += I24::ONE; | ||
| } |
Contributor
There was a problem hiding this comment.
tick spacing can be up to 2^15-1 in theory, best to make this a constant expr, smth like if ... != I24:ZERO { start_tick += self.tick_spacing - start_tick % self.tick_spacing }
Comment on lines
+221
to
+223
| while start_tick % I24::unchecked_from(self.tick_spacing) != I24::ZERO { | ||
| start_tick += I24::ONE; | ||
| } |
Contributor
There was a problem hiding this comment.
Same here, don't use loop maybe?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.