chore: add op angstrom tests (without generics)#624
Open
estensen wants to merge 75 commits intofeat/rollup-compatfrom
Open
chore: add op angstrom tests (without generics)#624estensen wants to merge 75 commits intofeat/rollup-compatfrom
estensen wants to merge 75 commits intofeat/rollup-compatfrom
Conversation
chore: speed up compilation and improve maxperf perf
fix: handle shutdown more gracefully
chore: give each CI job cache key
Collaborator
|
@jnoorchashm37 can you take a look at this given you built the test harness |
Will-Smith11
reviewed
Oct 9, 2025
Collaborator
Will-Smith11
left a comment
Will-Smith11
left a comment
There was a problem hiding this comment.
looks fine. Curious if you where able to get devnet up and running
Comment on lines
+121
to
+134
| // impl<S: AngstromMetaSigner> NetworkWallet<Ethereum> for AngstromSigner<S> { | ||
| // fn default_signer_address(&self) -> Address { | ||
| // self.address() | ||
| // } | ||
|
|
||
| // /// Return true if the signer contains a credential for the given | ||
| // address. fn has_signer_for(&self, address: &Address) -> bool { | ||
| // address == &self.address() | ||
| // } | ||
|
|
||
| // /// Return an iterator of all signer addresses. | ||
| // fn signer_addresses(&self) -> impl Iterator<Item = Address> { | ||
| // vec![self.address()].into_iter() | ||
| // } |
Comment on lines
-51
to
+52
| let tx_hash = *tx.tx_hash(); | ||
| // TODO(mempirate): MAY BE WRONG | ||
| let tx_hash = keccak256(&encoded_tx); |
Collaborator
There was a problem hiding this comment.
should actually be deleted. we don't use this afaik
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ran into constraint issues with
EthereumWalletand different network tx types. Currently not possible to make generic with alloy.Resetting testing-tools dir and duplicating it to op-testing-tools