Open
Conversation
only edits to test file
still a WIP; multiple tests currently failing
also add helper for fetching uniswap pending rewards and move `setAngstromLastBlockUpdated` function into BaseTest
… them also minor formatting fixes & cleanup
xenide
requested changes
Apr 10, 2026
| using AngstromView for IAngstromAuth; | ||
|
|
||
| IAngstromAuth public immutable angstrom; | ||
| IPoolManager public immutable uniswapPoolManager; |
There was a problem hiding this comment.
seems like this storage variable is not used in the smart contract code at all? after being set in the constructor
Also noticed that in some functions such as pendingRewards below it requires the caller to pass in IPoolManager uniV4. So maybe we need to de-conflict here?
Author
There was a problem hiding this comment.
ah yes, I meant to just eliminate this input from these functions, thanks for noticing
Comment on lines
+188
to
+189
| console.log("asset0: %s", asset0); | ||
| console.log("asset1: %s", asset1); |
There was a problem hiding this comment.
I think maybe you didn't mean to commit these console logs
| new AngstromInspector(IAngstromAuth(angstrom), IPoolManager(uniswap)); | ||
|
|
||
| vm.stopBroadcast(); | ||
| console.log("[INFO] deployed apdater to %s", address(inspector)); |
| import {Positions, Position} from "../types/Positions.sol"; | ||
| import {StateLibrary} from "v4-core/src/libraries/StateLibrary.sol"; | ||
|
|
||
| using PoolIdLibrary for PoolId; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AngstromViewlibrary, particularly for aiding in queries of LP positions and their rewardsAngstromInspectorwhich exposes library functions, so that users can simply call this contract's functions for queriesAngstromInspectorcontract