Skip to content

Add schema-backed NLBoot evidence validation#4

Closed
Copilot wants to merge 3 commits intomainfrom
copilot/add-schema-backed-nlboot-validation
Closed

Add schema-backed NLBoot evidence validation#4
Copilot wants to merge 3 commits intomainfrom
copilot/add-schema-backed-nlboot-validation

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 30, 2026

  • Create JSON Schema for NLBoot evidence at fixtures/schemas/nlboot-evidence.v1.schema.json
  • Valid fixture: existing fixtures/sample_nlboot_evidence.json (passes validation)
  • Create invalid evidence fixture at fixtures/invalid_nlboot_evidence.json (fails with clear errors)
  • Update sourceosctl/commands/nlboot.py: add validate_evidence() + --validate path through inspect_evidence()
  • Update sourceosctl/cli.py: add --validate flag to nlboot evidence inspect + new nlboot evidence validate <path> subcommand
  • Update tests/test_cli.py: 9 new tests covering validation (valid, invalid, missing, bad JSON, unknown schema, flag, subcommand via main)
  • Update README.md: document new commands
  • make validate passes (30/30 tests, CodeQL clean)
  • No-op commit pushed to trigger CI rerun after workflow approval

Copilot AI changed the title [WIP] Add schema-backed NLBoot evidence validation to sourceosctl Add schema-backed NLBoot evidence validation Apr 30, 2026
Copilot AI requested a review from mdheller April 30, 2026 19:37
Copy link
Copy Markdown
Contributor

@copilot Scope looks aligned with issue #3, but this PR is still draft and validation is action-required. Please mark it ready when complete and push a no-op commit if needed to rerun checks after workflow approval. Keep scope unchanged and retain make validate evidence.

Co-authored-by: mdheller <21163552+mdheller@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Apr 30, 2026

@copilot Scope looks aligned with issue #3, but this PR is still draft and validation is action-required. Please mark it ready when complete and push a no-op commit if needed to rerun checks after wor...

Pushed a no-op commit (d6c2200) to rerun checks. make validate passes locally (30/30 tests, CodeQL clean). Scope is unchanged — the PR is ready for review.

@mdheller mdheller marked this pull request as ready for review April 30, 2026 22:07
@mdheller mdheller closed this Apr 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Agent task: add schema-backed NLBoot evidence validation

2 participants