Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 39665357a8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "hydra": "http://www.w3.org/ns/hydra/core#", | ||
| "prov": "http://www.w3.org/ns/prov#", | ||
| "@version": 1.1, | ||
| "srcos": "urn:sourceos:repo-ontology:", |
There was a problem hiding this comment.
Preserve existing type mappings in semantic context
Repointing srcos to urn:sourceos:repo-ontology: here effectively replaces the prior https://schemas.srcos.ai/v2/ vocabulary for the same semantic/context.jsonld path, so previously valid JSON-LD documents (for example those using @type: "Dataset" with this shared context) no longer expand to their established IRIs. Because consumers reference this file by URL, changing its semantics in place is a breaking compatibility regression for existing tooling.
Useful? React with 👍 / 👎.
| "@graph": [ | ||
| { | ||
| "@id": "rolePlatformWorkspaceController", | ||
| "@type": "TopologyRole", |
There was a problem hiding this comment.
Define TopologyRole as an explicit IRI term
Each ontology node uses @type: "TopologyRole", but TopologyRole is not declared in the loaded context and no @vocab is set, so JSON-LD expansion treats this as a relative IRI tied to the document base URL. That makes the class identifier environment-dependent instead of canonical, which undermines cross-repo reasoning over the role class.
Useful? React with 👍 / 👎.
|
@copilot fix the failed tests |
…0 for ajv-cli Agent-Logs-Url: https://github.com/SourceOS-Linux/sourceos-spec/sessions/5169c178-fe2c-403b-9bce-ffb72f30f056 Co-authored-by: mdheller <21163552+mdheller@users.noreply.github.com>
…e array pass Agent-Logs-Url: https://github.com/SourceOS-Linux/sourceos-spec/sessions/5169c178-fe2c-403b-9bce-ffb72f30f056 Co-authored-by: mdheller <21163552+mdheller@users.noreply.github.com>
Fixed in f0391b1. Two issues were addressed:
|
Summary
Adds the first machine-readable repo-topology starter pack for the SourceOS / AgentOS lane.
This PR introduces:
Why
The README topology work made the role map legible to humans. This PR makes it legible to machines.
The intended next step is for each core repo to publish a
semantic/repo.jsonlddescriptor that references this shared vocabulary instead of redefining its own ontology.