Numerical and mask correctness audit + fixes - #164
Merged
Conversation
pbower
force-pushed
the
arith_correctness
branch
2 times, most recently
from
August 14, 2026 18:04
79b66d1 to
33a2f9a
Compare
Fixes integer division contract (as it was thresholding instead of returning floats for Scalar) + Small mask correctness bugfixes + improvements : 1. Correct Value::len to report the window for an array view 2. Add get_unchecked and Copy to BitmaskV 3. Make guarantee_f64 return windowed null mask 4. Document and pin integer floor division contract 5. Ensure integer power validates its exponent and wraps on overflow 6. Ensure Integer division rounds towards negative infinity 7. Ensure scalar integer division is true division
pbower
force-pushed
the
arith_correctness
branch
from
August 14, 2026 18:20
33a2f9a to
c589768
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes integer division contract (as it was thresholding instead of returning floats for Scalar)
+ Small mask correctness bugfixes + improvements :