Increase all tolerances to 1e-9#226
Open
pklampros wants to merge 2 commits intoSpaceGroupUCL:masterfrom
Open
Conversation
blsemo
reviewed
Aug 22, 2018
Collaborator
blsemo
left a comment
blsemo
left a comment
There was a problem hiding this comment.
Hmm, maybe setting everything to 1e-9 is a bit simplistic. Ideally, we'd look at all the tolerances, figure out what they exactly mean and what values they are usually compared against.
…nto increase_tolerances
pklampros
force-pushed
the
increase_tolerances
branch
from
816fd0a to
6e809e7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.