Fix algorithm selection issue - add missing cityMap to algorithms array#15
Closed
Fix algorithm selection issue - add missing cityMap to algorithms array#15
Conversation
Copilot
AI
changed the title
[WIP] FIx issue where no matter what algormim is picked in map config
Fix algorithm selection issue - add missing cityMap to algorithms array
Aug 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue where the cityMap algorithm was not accessible through the UI algorithm cycling, despite being fully implemented and set as the default in DungeonConfig.
Problem
The game defines 4 dungeon generation algorithms in
GenerationAlgorithmenum:roomsCorridorsbspcellularcityMap(default algorithm)However, the
GameScene.algorithmsarray only contained 3 algorithms, missingcityMap:This meant that:
.cityMapwas always overridden by the limited selectionSolution
Added the missing
.cityMapalgorithm to the algorithms array:Verification
testAllAlgorithmsAvailable()to prevent future regressionsThe fix is minimal and surgical, addressing the root cause without modifying any existing logic.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.