Calculate suspension velocity for ac#40
Open
wasabinator wants to merge 1 commit intoSpacefreak18:masterfrom
Open
Calculate suspension velocity for ac#40wasabinator wants to merge 1 commit intoSpacefreak18:masterfrom
wasabinator wants to merge 1 commit intoSpacefreak18:masterfrom
Conversation
Owner
|
This is great. Like I was saying in the simapi commit, if you think this is good, I say we just make this the default way to do suspension effects. So that would eliminate much of the boilerplate you had to do for this. Just use your new simdata->suspensionvelocity[] variable where necessary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The suspension velocity in the sim data isn't currently plumbed through to provide haptic effects, so this change implements that.
The changes I raised against simapi for the acmapper allow the effects to work from AC.
Example config used to test