feat(registry): add GitHub MCP server authentication setup#15
feat(registry): add GitHub MCP server authentication setup#15
Conversation
Document implementation approach for adding GitHub fine-grained personal access token authentication with comprehensive permission requirements. Relates to #9
|
Note that https://www.npmjs.com/package/@modelcontextprotocol/server-github is actually deprecated, so we should use https://github.com/github/github-mcp-server. We should review docs to make sure that the cli is still compatible with the example above. |
|
once we have the pat and have validated its structure, let's also validate it by test calls to the endpoints the mcp needs. if it's easier, we could do that by spawning the mcp process in our validation step and making the rpc calls directly. if the scopes are insufficient, we should advise the user of additional scopes to add. we should also ensure that the scopes provide access to the current repository (if one of the git remotes is github). |
|
actually, it might make sense to abstract that functionality so each registry item has its own set of validation calls it can make to the mcp to ensure that it's working with the appropriate credentials, etc. we'll create that as a separate github issue for all existing mcps. |
Summary
Adds authentication setup for GitHub MCP server to enable repository operations, issue management, pull request workflows, and comprehensive GitHub integration from Claude Code.
Implementation Plan
See docs/features/009-github-authentication.md for detailed implementation approach.
Key Components
Registry Updates:
registry/mcp-servers/github/index.tsconfigure()lifecycle methodAuthentication Flow:
github_pat_).env.mcp.secretsasGITHUB_PERSONAL_ACCESS_TOKENDocumentation:
registry/mcp-servers/github/claude.mdCLAUDE.md Integration:
Technical Approach
Testing Strategy
GitHub MCP Capabilities
Repository Operations
Issue Management
Pull Request Workflows
Advanced Features
Required Permissions Breakdown
Minimum Required (read + write)
contents
issues
pull_requests
actions
discussions
workflows
Minimum Required (read)
metadata
notifications
Optional Enhanced Permissions
administration (read + write)
security_events (read + write)
vulnerability_alerts (read + write)
deployments (read + write)
Areas Requesting Feedback
1. Token Testing
Question: Should we test the token during setup?
Pros:
Cons:
Recommendation: Optional validation with
--skip-validationflag2. Permission Error Handling
Question: How should we handle permission errors during usage?
Context:
Options:
Recommendation: Combination of A and C
3. Multi-Account Support
Question: Should we support multiple GitHub accounts/tokens?
Use Cases:
Implementation:
Recommendation: Document multi-server pattern, defer implementation
4. Workflow Examples Priority
Question: Which GitHub workflows should we document first?
Options (vote with 👍):
Recommendation: Option F with practical examples for each
Related Issues
Closes #9
Checklist
Status: 🚧 Draft - Implementation plan complete, awaiting feedback before coding