Skip to content

added 2x1 widget #41 #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hrprt96 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

added 2x1 widget #41 #53

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 18 additions & 9 deletions app/src/main/AndroidManifest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@
tools:targetApi="n">
<activity
android:name=".GlobalActivity"
android:screenOrientation="portrait"
android:label="@string/app_name">
android:label="@string/app_name"
android:screenOrientation="portrait">
<intent-filter>
<action android:name="android.intent.action.MAIN" />

Expand All @@ -33,35 +33,35 @@
android:name=".activity.AboutActivity"
android:configChanges="locale"
android:label="About"
android:screenOrientation="portrait"
android:parentActivityName=".activity.WeatherActivity">
android:parentActivityName=".activity.WeatherActivity"
android:screenOrientation="portrait">
<meta-data
android:name="android.support.PARENT_ACTIVITY"
android:value="com.a5corp.weather.activity.WeatherActivity" />
</activity>
<activity
android:name=".activity.WeatherActivity"
android:configChanges="locale"
android:screenOrientation="portrait"
android:label="@string/app_name"
android:screenOrientation="portrait"
tools:targetApi="n" />
<activity
android:name=".activity.FirstLaunch"
android:configChanges="locale"
android:label="Enter City"
android:screenOrientation="portrait"
android:resizeableActivity="false"
android:screenOrientation="portrait"
tools:targetApi="n" />
<activity
android:name=".activity.LicenseActivity"
android:configChanges="locale"
android:screenOrientation="portrait"
android:label="License" />
android:label="License"
android:screenOrientation="portrait" />
<activity
android:name=".activity.settings.SettingsActivity"
android:configChanges="locale"
android:screenOrientation="portrait"
android:label="@string/settings"
android:screenOrientation="portrait"
android:theme="@style/AppTheme">
<meta-data
android:name="android.support.PARENT_ACTIVITY"
Expand Down Expand Up @@ -111,6 +111,15 @@
android:name="android.appwidget.provider"
android:resource="@xml/small_widget" />
</receiver>
<receiver android:name=".Very_small_widget">
Copy link
Copy Markdown
Owner

@Sparker0i Sparker0i Dec 21, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • It should be placed inside the widget sub-package. I can see that it is in the root package. Please make that change
  • Please follow the naming convention of other receivers. Other receiver names are following PascalCasing.
  • I don't see Very_small_widget and very_small_widget_info.xml files. How is this even working then? Are you sure you had committed those 2 files?

<intent-filter>
<action android:name="android.appwidget.action.APPWIDGET_UPDATE" />
</intent-filter>

<meta-data
android:name="android.appwidget.provider"
android:resource="@xml/very_small_widget_info" />
</receiver>
</application>

</manifest>
Binary file added app/src/main/res/drawable-nodpi/example_appwidget_preview.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
10 changes: 10 additions & 0 deletions app/src/main/res/values-v14/dimens.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
<?xml version="1.0" encoding="utf-8"?>
<resources>

<!--
Refer to App Widget Documentation for margin information
http://developer.android.com/guide/topics/appwidgets/index.html#CreatingLayout
-->
<dimen name="widget_margin">0dp</dimen>

</resources>
6 changes: 6 additions & 0 deletions app/src/main/res/values/dimens.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,10 @@
<dimen name="font_normal">12sp</dimen>

<dimen name="margin_normal">10dp</dimen>

<!--
Refer to App Widget Documentation for margin information
http://developer.android.com/guide/topics/appwidgets/index.html#CreatingLayout
-->
<dimen name="widget_margin">8dp</dimen>
</resources>
3 changes: 3 additions & 0 deletions app/src/main/res/values/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,4 +103,7 @@
<!-- Graph Strings -->
<string name="g_pressure">Pressure, hPa</string>
<string name="g_snow">Snow, mm</string>
<string name="appwidget_text">EXAMPLE</string>
<string name="configure">Configure</string>
<string name="add_widget">Add widget</string>
</resources>