Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR expands the edge-description documentation to better explain what each Okta/BloodHound edge represents and how it relates to downstream impact in the overall attack-path model.
Changes:
- Refines “General Information” phrasing for multiple edges to clarify semantics (traversable vs non-traversable, directionality, and what the edge does/doesn’t prove).
- Adds structured sections (e.g., Abuse Info, Cleanup after Abuse, Opsec Considerations, References) across many edge docs for consistency and completeness.
- Updates/standardizes examples and diagrams (Mermaid graphs, terminology like GitHub capitalization, AD_* naming in diagrams).
Reviewed changes
Copilot reviewed 47 out of 47 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| descriptions/edges/Okta_UserSync.md | Expands edge documentation with detailed usage/impact sections and updated diagram. |
| descriptions/edges/Okta_UserPush.md | Adds structured guidance sections and refines provisioning wording. |
| descriptions/edges/Okta_UserPull.md | Clarifies non-traversable import semantics and adds structured guidance sections. |
| descriptions/edges/Okta_SWA.md | Clarifies SWA semantics and adds structured guidance sections. |
| descriptions/edges/Okta_SuperAdmin.md | Adds structured guidance sections for Super Admin impact and response. |
| descriptions/edges/Okta_ResourceSetContains.md | Adds structured guidance sections for resource-set scoping implications. |
| descriptions/edges/Okta_ResetPassword.md | Adds structured guidance sections for password reset impact and response. |
| descriptions/edges/Okta_ResetFactors.md | Adds structured guidance sections for factor reset impact and response. |
| descriptions/edges/Okta_RealmContains.md | Adds structured guidance sections for realm membership implications. |
| descriptions/edges/Okta_ReadPasswordUpdates.md | Refines edge definition and adds structured guidance sections. |
| descriptions/edges/Okta_OutboundSSO.md | Refines SSO description and adds structured guidance sections. |
| descriptions/edges/Okta_OutboundOrgSSO.md | Refines org-level SSO description, fixes capitalization, and adds structured guidance sections. |
| descriptions/edges/Okta_OrgSWA.md | Refines org-level SWA description and adds structured guidance sections. |
| descriptions/edges/Okta_OrgAdmin.md | Adds structured guidance sections for Org Admin impact and response. |
| descriptions/edges/Okta_MobileAdmin.md | Adds structured guidance sections for device-admin impact and response. |
| descriptions/edges/Okta_MembershipSync.md | Clarifies directionality/examples and adds structured guidance sections. |
| descriptions/edges/Okta_MemberOf.md | Adds structured guidance sections describing group entitlement implications. |
| descriptions/edges/Okta_ManagerOf.md | Adds structured guidance sections for manager-metadata implications. |
| descriptions/edges/Okta_ManageApp.md | Adds structured guidance sections for custom-role app management implications. |
| descriptions/edges/Okta_KerberosSSO.md | Refines Agentless Desktop SSO description and adds structured guidance sections. |
| descriptions/edges/Okta_InboundSSO.md | Refines inbound SSO definition and adds structured guidance sections. |
| descriptions/edges/Okta_IdpGroupAssignment.md | Refines IdP group assignment semantics and adds structured guidance sections. |
| descriptions/edges/Okta_IdentityProviderFor.md | Refines IdP linkage semantics and adds structured guidance sections. |
| descriptions/edges/Okta_HelpDeskAdmin.md | Adds structured guidance sections for help desk admin impact and response. |
| descriptions/edges/Okta_HasRoleAssignment.md | Adds structured guidance sections for role-assignment object implications. |
| descriptions/edges/Okta_GroupPush.md | Clarifies edge direction/source semantics and adds structured guidance sections. |
| descriptions/edges/Okta_GroupPull.md | Refines import semantics and adds structured guidance sections. |
| descriptions/edges/Okta_GroupMembershipAdmin.md | Adds structured guidance sections for membership-admin impact and response. |
| descriptions/edges/Okta_GroupAdmin.md | Adds structured guidance sections for group admin impact and response. |
| descriptions/edges/Okta_DeviceOf.md | Adds structured guidance sections for device-to-user association implications. |
| descriptions/edges/Okta_CreatorOf.md | Adds structured guidance sections for integration-creator metadata implications. |
| descriptions/edges/Okta_Contains.md | Refines containment semantics and adds structured guidance sections. |
| descriptions/edges/Okta_AppAssignment.md | Adds structured guidance sections for assignment implications and response. |
| descriptions/edges/Okta_AppAdmin.md | Adds structured guidance sections for app-admin impact and response. |
| descriptions/edges/Okta_ApiTokenFor.md | Adds structured guidance sections for SSWS token ownership implications. |
| descriptions/edges/Okta_AddMember.md | Adds structured guidance sections for scoped group membership changes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.