Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix npm install failure caused by the native canvas package requiring system-level C++ libraries (Cairo, Pango, etc.) that may not be present on all machines. Make canvas optional with a graceful runtime fallback.
Changes
Move canvas from dependencies to optionalDependencies in package.json so npm install no longer fails when native build tools are missing
Refactor pdf-image-extractor.ts to use lazy dynamic import("canvas") instead of a static import, with automatic fallback to text-only PDF extraction when canvas is unavailable
Export isCanvasAvailable() helper for callers that need to check canvas availability
Add "Optional: PDF Image Extraction (canvas)" section to README.md with system dependency install commands for macOS, Ubuntu/Debian, Fedora/RHEL, and Windows
Related Issues
Type of Change
Checklist
npm test)npm run lint)