-
Notifications
You must be signed in to change notification settings - Fork 240
Compute saturation intervals ala IBL #4301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
oliche
wants to merge
25
commits into
SpikeInterface:main
Choose a base branch
from
int-brain-lab:sat_detection
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+299
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
…ace into sat_detection
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…ace into sat_detection
alejoe91
reviewed
Jan 8, 2026
Member
alejoe91
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we apply this directly in the int16 space?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ports the saturation method from IBL. It will introduce a new data type for holding information on events / periods of noise / saturation etc.
This will also require:
silence_periods.pyto handle this new data typeOther notes:
remove_artefacts.pyhandles a slightly different use case (triggers at known timepoints contaminating the recording, which may also be imputed with a model-based approach) and so is not considered hereQuestions:
computethe data is cast tofloat64and then scaled withgainsandoffset. To confirm, is there any situation where this data might already be scaled? I guess if the data is scaled, gain is1and offset is0anyway.float64was chosen for the extra precision as IBL are working in voltsmute_window_samplesbe scaled based on thefs? (currently 7 samples assumes NP1)return_scaledorscale_to_uVpreferred now? Just a note in the docstringdetect_saturation()docstring? I will also double check but good to get another pair of eyes on thisTo discuss
Documentation
It would be nice to add a documentation page for this once the applier-function is done as the application is a little non-standard i.e. should be estimated on the raw data, and applied on the preprocessed data. Some of the values should also be empirically estimated / are dependent on the probe, this has really designed for NP1 as I understand it.