Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 46 additions & 0 deletions .agents/tasks/938-move-codegen-request-writer.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
---
slug: 938-move-codegen-request-writer
branch: claude/busy-dirac-wwflbm
owner: claude
status: in-progress
started: 2026-06-10
---

## Goal

`io.spine.code.proto.CodeGeneratorRequestWriter` is removed from `base`
(it is protoc-plugin tooling, not runtime API), and the build is green.
Closes [#938](https://github.com/SpineEventEngine/base-libraries/issues/938)
together with the receiving change in `tool-base`.

## Context

- The class moves to the `tool-base` module of the ToolBase repository under
`io.spine.tools.code.proto` (same-named branch there).
- The only consumers are the protoc-plugin entry points of the Compiler and
ProtoTap; they migrate by switching the import once both PRs are published.
- `CodeGeneratorRequestParsingSpec.kt` and `CodeGeneratorRequestsJavaSpec.java`
stay: they test `io.spine.type` parsing APIs which remain in `base`, and the
Java spec still uses the `constructRequest` helper declared in the former.
- Removing public API is a breaking change: the snapshot version advances to
the next multiple of 10.

## Plan

- [x] Remove `base/src/main/kotlin/io/spine/code/proto/CodeGeneratorRequestWriter.kt`.
- [x] Remove `base/src/test/kotlin/io/spine/code/proto/CodeGeneratorRequestWriterSpec.kt`.
- [x] Bump version `2.0.0-SNAPSHOT.404` -> `2.0.0-SNAPSHOT.410` (breaking).
- [ ] `./gradlew build` green; commit regenerated dependency reports if any.
- Blocked in the sandbox: all Spine artifact repositories return 403 for
the buildscript dependency `io.spine.tools:protobuf-setup-plugins`, so
no Gradle build can run here at all. Verification is delegated to PR CI.
- Repo-wide greps confirm no remaining references to the removed class;
the surviving `CodeGeneratorRequest*` specs do not use it.
- [x] Push and open a draft PR; merge after the tool-base PR.

## Log

- 2026-06-10 — drafted; executing autonomously per issue #938.
- 2026-06-10 — removal committed and version bumped; sandbox cannot resolve
Spine snapshot artifacts (403 on all repos), so the build runs on PR CI
instead.

This file was deleted.

This file was deleted.

8 changes: 4 additions & 4 deletions docs/dependencies/dependencies.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@


# Dependencies of `io.spine:spine-annotations:2.0.0-SNAPSHOT.404`
# Dependencies of `io.spine:spine-annotations:2.0.0-SNAPSHOT.410`

## Runtime
1. **Group** : org.jetbrains. **Name** : annotations. **Version** : 26.1.0.
Expand Down Expand Up @@ -767,7 +767,7 @@ This report was generated on **Mon Jun 08 18:37:28 WEST 2026** using



# Dependencies of `io.spine:spine-base:2.0.0-SNAPSHOT.404`
# Dependencies of `io.spine:spine-base:2.0.0-SNAPSHOT.410`

## Runtime
1. **Group** : com.google.code.findbugs. **Name** : jsr305. **Version** : 3.0.2.
Expand Down Expand Up @@ -1611,7 +1611,7 @@ This report was generated on **Mon Jun 08 18:37:29 WEST 2026** using



# Dependencies of `io.spine:spine-environment:2.0.0-SNAPSHOT.404`
# Dependencies of `io.spine:spine-environment:2.0.0-SNAPSHOT.410`

## Runtime
1. **Group** : com.google.code.findbugs. **Name** : jsr305. **Version** : 3.0.2.
Expand Down Expand Up @@ -2437,7 +2437,7 @@ This report was generated on **Mon Jun 08 18:37:28 WEST 2026** using



# Dependencies of `io.spine:spine-format:2.0.0-SNAPSHOT.404`
# Dependencies of `io.spine:spine-format:2.0.0-SNAPSHOT.410`

## Runtime
1. **Group** : com.fasterxml.jackson. **Name** : jackson-bom. **Version** : 2.22.0.
Expand Down
2 changes: 1 addition & 1 deletion docs/dependencies/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ all modules and does not describe the project structure per-subproject.
-->
<groupId>io.spine</groupId>
<artifactId>base-libraries</artifactId>
<version>2.0.0-SNAPSHOT.404</version>
<version>2.0.0-SNAPSHOT.410</version>

<inceptionYear>2015</inceptionYear>

Expand Down
4 changes: 2 additions & 2 deletions version.gradle.kts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright 2025, TeamDev. All rights reserved.
* Copyright 2026, TeamDev. All rights reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand All @@ -24,4 +24,4 @@
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/

val versionToPublish: String by extra("2.0.0-SNAPSHOT.404")
val versionToPublish: String by extra("2.0.0-SNAPSHOT.410")
Loading