Trigger publishing - #947
Merged
Merged
Conversation
alexander-yevsyukov
marked this pull request as ready for review
June 16, 2026 16:14
alexander-yevsyukov
enabled auto-merge
June 16, 2026 16:15
armiol
approved these changes
Jun 16, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR increments the published snapshot version and updates build tooling/report generation to correctly write and deduplicate dependencies (including semantic version comparison and proper Maven scopes), plus regenerates dependency documentation and adjusts CI to run Dokka.
Changes:
- Bump snapshot version from
2.0.0-SNAPSHOT.412to2.0.0-SNAPSHOT.413across Gradle and docs. - Improve dependency
pom.xmlgeneration: omitnullversions, deduplicate by semantic version ordering, and prefer the widest/highest-ranking Maven scope for the retained version. - Add buildSrc tests for version comparison and dependency writing; update CI to run
dokkaGenerateon pushes.
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| version.gradle.kts | Bumps versionToPublish to trigger publishing. |
| docs/dependencies/pom.xml | Regenerates dependency POM output (no <version>null</version>, scope/version ordering changes). |
| docs/dependencies/dependencies.md | Regenerates dependency/license report for the new snapshot. |
| config | Updates submodule pointer. |
| buildSrc/src/main/kotlin/io/spine/gradle/report/pom/VersionComparator.kt | Adds semantic-ish version comparator used for dependency selection. |
| buildSrc/src/main/kotlin/io/spine/gradle/report/pom/DependencyWriter.kt | Updates XML writing to omit null versions; updates deduplication logic to use semantic version + scope priority. |
| buildSrc/src/main/kotlin/io/spine/gradle/report/pom/ScopedDependency.kt | Updates scope ordering/priority (incl. provided, system, undefined) and docs. |
| buildSrc/src/test/kotlin/io/spine/gradle/report/pom/VersionComparatorSpec.kt | Adds tests for version comparison semantics. |
| buildSrc/src/test/kotlin/io/spine/gradle/report/pom/DependencyWriterSpec.kt | Adds tests for deduplication, scope merging, ordering, and null-version omission. |
| buildSrc/src/main/kotlin/io/spine/gradle/publish/GitHubPackages.kt | Clarifies token KDoc wording. |
| buildSrc/src/main/kotlin/io/spine/dependency/local/ProtoTap.kt | Bumps ProtoTap version. |
| buildSrc/src/main/kotlin/io/spine/dependency/local/ProtoData.kt | Removes ProtoData dependency helper object. |
| buildSrc/src/main/kotlin/io/spine/dependency/local/McJava.kt | Removes McJava dependency helper object. |
| buildSrc/src/main/kotlin/BuildExtensions.kt | Removes mcJava shortcut and updates related KDoc. |
| .github/workflows/build-on-ubuntu.yml | Runs dokkaGenerate alongside build to surface Dokka warnings pre-merge. |
| */ | ||
|
|
||
| val versionToPublish: String by extra("2.0.0-SNAPSHOT.412") | ||
| val versionToPublish: String by extra("2.0.0-SNAPSHOT.413") |
Comment on lines
+195
to
+203
| val groups = dependencies.groupBy { it.run { "$group:$name" } } | ||
|
|
||
| logDuplicates(groups) | ||
| logDuplicates(groups.mapValues { (_, deps) -> deps.distinctBy { it.gav } }) | ||
|
|
||
| val filtered = groups.map { group -> | ||
| group.value.maxByOrNull { dep -> dep.version ?: "" } | ||
| }.filterNotNull() | ||
| val filtered = groups.values.map { sameArtifact -> | ||
| val newest = sameArtifact.maxWith(compareBy(VersionComparator) { it.version ?: "" }) | ||
| sameArtifact.filter { it.version == newest.version } | ||
| .minBy { it.scoped.dependencyPriority() } | ||
| } |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #947 +/- ##
=======================================
Coverage 94.04% 94.04%
=======================================
Files 192 192
Lines 4149 4149
Branches 339 339
=======================================
Hits 3902 3902
Misses 147 147
Partials 100 100 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR bumps the version to trigger publishing which (mysteriously) did not happen for the previous PR.
Latest
configwas also applied.