Remove the retired ModelCompiler object in migrate; bump Testcontainers to 2.0.5 - #740
Merged
Merged
Conversation
`ModelCompiler.kt` was dropped from `config` in cce5f57, but `migrate` was not updated to delete stale consumer copies. Since `cp -R buildSrc ..` only overlays sources and never deletes, consumers that pulled earlier keep a `ModelCompiler.kt` that no longer belongs to `buildSrc`. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Testcontainers 2.x prefixes every module artifact with `testcontainers-`; only the core library keeps the plain `testcontainers` name. Verified on Maven Central at 2.0.5: `junit-jupiter`, `gcloud`, and `mysql` return 404, while the prefixed coordinates resolve. Also adds the `postgresql` constant so config's copy is a superset of the consumer usages (gcloud-jvm and jdbc-storage), which keeps the next float from breaking `rdbms/build.gradle.kts` with an unresolved reference. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
ModelCompiler dependency object in migrateModelCompiler object in migrate; bump Testcontainers to 2.0.5
alexander-yevsyukov
enabled auto-merge (squash)
August 5, 2026 17:43
armiol
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two independent
buildSrc-distribution fixes.1.
migrate— remove the retiredModelCompilerdependency objectModelCompiler.ktwas dropped fromconfigin cce5f57 ("Remove outdated localdependency"), but
migratewas never updated to delete stale copies in consumerrepositories.
migratedistributesbuildSrcwithcp -R buildSrc .., which is a pure overlay:it adds and overwrites, but never deletes. So every file
configretires needs anexplicit
rm -f, otherwise a consumer that pulled earlier keeps the retired objectforever — and
buildSrccompiles as a single Kotlin source set, so a leftoverobject can break the consumer's build.
ModelCompiler.ktnow joins the existing removal block next toProtoData.ktandMcJava.kt, and the block comment records the supersession chain:Model Compiler → McJava → CoreJvm Compiler (
io.spine.core-jvm).2.
Testcontainers— bump to 2.0.5 with the 2.x artifact namesTestcontainers 2.x prefixes every module artifact with
testcontainers-; only thecore library keeps the plain
testcontainersname.Testcontainers.ktnow pins2.0.5with the 2.x coordinates, soconfigfloats stop reverting consumers thatalready upgraded (gcloud-jvm PR #202) and stop breaking their
Testcontainers-2.x-based sources.
Also adds a
postgresqlconstant soconfig's copy is a superset of the consumerusages —
jdbc-storage/rdbms/build.gradle.ktsreferences it, and without it thenext float breaks that build script with an unresolved reference.
Note the constant names (
junitJupiter,gcloud,mySql) are unchanged — onlytheir coordinate values move — so no consumer reference breaks and no
@Deprecatedshim is owed.
postgresqlintentionally keeps its lowercase spelling rather thanmatching
mySql's camelCase, because that is the name jdbc-storage alreadyreferences.
Verification
./gradlew -p buildSrc buildpasses (JDK 17).bash -n migratepasses; the addedrm -fpath matches the historical file pathexactly, sits inside the
IS_JVMblock aftercp -R buildSrc .., andrm -fkeeps re-runs a no-op.
testcontainers,testcontainers-junit-jupiter,testcontainers-gcloud,testcontainers-mysql, andtestcontainers-postgresqlall resolve, while theold unprefixed
junit-jupiter,gcloud, andmysqlreturn 404. 2.0.5 is thecurrent release per
maven-metadata.xml.dependency-audit: APPROVE — no version downgrade, no removed symbols, nostale coordinates left in the repo, copyright current.
version.gradle.kts, so the version gate is notapplicable.
🤖 Generated with Claude Code