-
Notifications
You must be signed in to change notification settings - Fork 1
Centralize errors formatting #72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| // Copyright 2026, TeamDev. All rights reserved. | ||
| // | ||
| // Redistribution and use in source and/or binary forms, with or without | ||
| // modification, must retain the above copyright notice and the following | ||
| // disclaimer. | ||
| // | ||
| // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS | ||
| // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT | ||
| // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR | ||
| // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT | ||
| // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, | ||
| // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT | ||
| // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, | ||
| // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY | ||
| // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT | ||
| // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE | ||
| // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. | ||
|
|
||
| package logging | ||
|
|
||
| import ( | ||
| "fmt" | ||
| "strings" | ||
| ) | ||
|
|
||
| // FormatError formats a single error inline and joined errors as a bullet list. | ||
| func FormatError(message string, err error) string { | ||
| errs := flattenedErrors(err) | ||
| if len(errs) <= 1 { | ||
| return fmt.Sprintf("%s: %v", message, err) | ||
| } | ||
|
|
||
| var builder strings.Builder | ||
| builder.WriteString(message) | ||
| builder.WriteString(":") | ||
| for _, nestedErr := range errs { | ||
| builder.WriteString("\n - ") | ||
| builder.WriteString(nestedErr.Error()) | ||
| } | ||
|
|
||
| return builder.String() | ||
| } | ||
|
|
||
| // flattenedErrors returns the leaf errors from a joined error. | ||
| func flattenedErrors(err error) []error { | ||
| joined, ok := err.(interface { | ||
| Unwrap() []error | ||
| }) | ||
| if !ok { | ||
| return []error{err} | ||
| } | ||
|
|
||
| var result []error | ||
| for _, nestedErr := range joined.Unwrap() { | ||
| result = append(result, flattenedErrors(nestedErr)...) | ||
| } | ||
|
|
||
| return result | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,78 @@ | ||
| // Copyright 2026, TeamDev. All rights reserved. | ||
| // | ||
| // Redistribution and use in source and/or binary forms, with or without | ||
| // modification, must retain the above copyright notice and the following | ||
| // disclaimer. | ||
| // | ||
| // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS | ||
| // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT | ||
| // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR | ||
| // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT | ||
| // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, | ||
| // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT | ||
| // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, | ||
| // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY | ||
| // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT | ||
| // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE | ||
| // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. | ||
|
|
||
| package logging_test | ||
|
|
||
| import ( | ||
| "errors" | ||
| "fmt" | ||
|
|
||
| "embed-code/embed-code-go/logging" | ||
|
|
||
| . "github.com/onsi/ginkgo/v2" | ||
| . "github.com/onsi/gomega" | ||
| ) | ||
|
|
||
| var _ = Describe("Error formatting", func() { | ||
|
Comment on lines
+21
to
+31
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
|
|
||
| It("should format a single error inline", func() { | ||
| err := errors.New("first failure") | ||
|
|
||
| Expect(logging.FormatError("operation failed", err)).To( | ||
| Equal("operation failed: first failure"), | ||
| ) | ||
| }) | ||
|
|
||
| It("should format a nested error inline", func() { | ||
| err := fmt.Errorf("outer context: %w", errors.New("first failure")) | ||
|
|
||
| Expect(logging.FormatError("operation failed", err)).To( | ||
| Equal("operation failed: outer context: first failure"), | ||
| ) | ||
| }) | ||
|
|
||
| It("should format joined errors as a bullet list", func() { | ||
| err := errors.Join( | ||
| errors.New("first failure"), | ||
| errors.New("second failure"), | ||
| ) | ||
|
|
||
| Expect(logging.FormatError("operation failed", err)).To( | ||
| Equal("operation failed:\n" + | ||
| " - first failure\n" + | ||
| " - second failure"), | ||
| ) | ||
| }) | ||
|
|
||
| It("should flatten nested joined errors into a bullet list", func() { | ||
| err := errors.Join( | ||
| errors.New("first failure"), | ||
| errors.Join( | ||
| errors.New("second failure"), | ||
| errors.New("third failure"), | ||
| ), | ||
| ) | ||
|
|
||
| Expect(logging.FormatError("operation failed", err)).To( | ||
| Equal("operation failed:\n" + | ||
| " - first failure\n" + | ||
| " - second failure\n" + | ||
| " - third failure"), | ||
| ) | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Equal("operation failed:\n" +
"- first failure\n" +
"- second failure\n" +
"- third failure"), |
||
| }) | ||
| }) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this function name lowercase, while the function above is uppercase?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Oleg-Melnik In GoLang, names that start with an uppercase letter are exported, meaning they can be accessed from other packages. Names that start with a lowercase letter are unexported and can be used only within the same package. This convention provides simple visibility control without separate
publicorprivatekeywords.It's a very strange decision, but those are the rules of the language.
This is a docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In Go, names starting with an uppercase letter are public and accessible from other packages. Names starting with a lowercase letter are private to their package.