Add Detekt configuration - #22
Conversation
Oleg-Melnik
left a comment
Oleg-Melnik
left a comment
There was a problem hiding this comment.
Reviewed the Detekt setup. It is well-scoped and I verified locally that ./gradlew detekt passes against the committed baseline, that detekt is wired into check, and that configuration cache is preserved. Detekt correctly analyzes main, test, and functionalTest sources (the *Spec.kt complexity/naming excludes confirm the large functional spec is in scope). Only two optional nits below; no blocking issues.
| LargeClass: | ||
| excludes: *testFiles | ||
| TooManyFunctions: | ||
| excludes: |
There was a problem hiding this comment.
Nit (consistency): TooManyFunctions.excludes re-lists the test-file globs literally, whereas every other rule in this file reuses the *testFiles YAML anchor defined on ClassNaming (line 3). Using excludes: *testFiles here too keeps the exclusion set defined in a single place, so future changes to which files count as tests only need one edit.
| */ | ||
| object Detekt { | ||
|
|
||
| // The alpha version is used, because latest stable version doesn't support JDK 25. |
There was a problem hiding this comment.
Nit (wording, optional): "because latest stable version doesn't support JDK 25" reads more naturally as "because the latest stable version does not support JDK 25" (add the article; the Spine writing style also tends to avoid contractions in doc prose).
Oleg-Melnik
left a comment
Oleg-Melnik
left a comment
There was a problem hiding this comment.
@Vladyslav-Kuksiuk LGTM with minor comments.
2 participants
This PR provides Detekt.
Resolves this issue.