Review and strip unused public API - #176
Merged
Merged
Conversation
All 13 elements in `tool-base` marked
`@SuppressWarnings("unused") /* Part of the public API. */` are verified
live: each has a downstream Spine consumer (mc-js, mc-dart,
core-jvm-compiler, doc-tools, protobuf-setup-plugins) and in-repo test
coverage. None are dead, so the suppressions are redundant and removed.
Fixes #11.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #176 +/- ##
============================================
- Coverage 90.22% 90.17% -0.05%
Complexity 552 552
============================================
Files 122 122
Lines 2230 2230
Branches 311 311
============================================
- Hits 2012 2011 -1
Misses 96 96
- Partials 122 123 +1 🚀 New features to boost your workflow:
|
armiol
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Resolves #11.
Reviewed every
tool-baseelement marked@SuppressWarnings("unused") /* Part of the public API. */and traced eachacross this repository's tests and downstream
SpineEventEngineconsumers.Finding: all 13 are genuinely live — each has a real downstream consumer
and in-repo test coverage. None are dead, so nothing was removed from the
API. Instead, the now-stale suppressions are dropped: recent test additions
mean the in-repo tests already satisfy the unused-declaration inspection, so
the annotations were redundant.
DefaultJsPathsProtocPluginPathDartFile.readJavadocText.fromUnescaped/inPreTagsDefaultJavaPaths.srcIndent.shiftedRight/shiftedLeftFileName.isJavaExternalModule.predefinedModulesExternalModules(ExternalModule...)/(Map<...>)FileWithImports.resolveImportsVerification
./gradlew build dokkaGenerate— BUILD SUCCESSFUL:tool-base:test— 219 passed, 0 failed, 1 skippedspine-code-reviewAPPROVE,kotlin-engineerAPPROVE2.0.0-SNAPSHOT.395→.396Note
This branch also carries two incidental maintenance commits that predate this
work (
Update config, and aKManifestSpectest-matcher cleanup).🤖 Generated with Claude Code