Skip to content

Review and strip unused public API - #176

Merged
alexander-yevsyukov merged 5 commits into
masterfrom
unused-public-api
Jun 8, 2026
Merged

Review and strip unused public API#176
alexander-yevsyukov merged 5 commits into
masterfrom
unused-public-api

Conversation

@alexander-yevsyukov

Copy link
Copy Markdown
Contributor

What

Resolves #11.

Reviewed every tool-base element marked
@SuppressWarnings("unused") /* Part of the public API. */ and traced each
across this repository's tests and downstream SpineEventEngine consumers.

Finding: all 13 are genuinely live — each has a real downstream consumer
and in-repo test coverage. None are dead, so nothing was removed from the
API. Instead, the now-stale suppressions are dropped: recent test additions
mean the in-repo tests already satisfy the unused-declaration inspection, so
the annotations were redundant.

Element Downstream consumer
DefaultJsPaths mc-js
ProtocPluginPath mc-dart
DartFile.read mc-dart
JavadocText.fromUnescaped / inPreTags core-jvm-compiler
DefaultJavaPaths.src protobuf-setup-plugins, core-jvm-compiler
Indent.shiftedRight / shiftedLeft mc-js
FileName.isJava doc-tools
ExternalModule.predefinedModules mc-js
ExternalModules(ExternalModule...) / (Map<...>) mc-js, mc-dart
FileWithImports.resolveImports mc-dart

Verification

  • ./gradlew build dokkaGenerateBUILD SUCCESSFUL
  • :tool-base:test — 219 passed, 0 failed, 1 skipped
  • Reviewers: spine-code-review APPROVE, kotlin-engineer APPROVE
  • Version bumped 2.0.0-SNAPSHOT.395.396

Note

This branch also carries two incidental maintenance commits that predate this
work (Update config, and a KManifestSpec test-matcher cleanup).

🤖 Generated with Claude Code

alexander-yevsyukov and others added 5 commits June 7, 2026 18:43
All 13 elements in `tool-base` marked
`@SuppressWarnings("unused") /* Part of the public API. */` are verified
live: each has a downstream Spine consumer (mc-js, mc-dart,
core-jvm-compiler, doc-tools, protobuf-setup-plugins) and in-repo test
coverage. None are dead, so the suppressions are redundant and removed.

Fixes #11.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@alexander-yevsyukov alexander-yevsyukov self-assigned this Jun 7, 2026
@codecov

codecov Bot commented Jun 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.17%. Comparing base (f80a009) to head (22f1284).

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #176      +/-   ##
============================================
- Coverage     90.22%   90.17%   -0.05%     
  Complexity      552      552              
============================================
  Files           122      122              
  Lines          2230     2230              
  Branches        311      311              
============================================
- Hits           2012     2011       -1     
  Misses           96       96              
- Partials        122      123       +1     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alexander-yevsyukov alexander-yevsyukov moved this to 🏗 In progress in v2.0 Jun 7, 2026
@alexander-yevsyukov
alexander-yevsyukov merged commit ef6f93b into master Jun 8, 2026
8 checks passed
@alexander-yevsyukov
alexander-yevsyukov deleted the unused-public-api branch June 8, 2026 13:32
@github-project-automation github-project-automation Bot moved this from 🏗 In progress to ✅ Done in v2.0 Jun 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Review unused public API

2 participants