Address deprecations - #178
Merged
Merged
Conversation
…gConventions` PMD 7.25.0 deprecated `category/java/codestyle.xml/GenericsNaming` (scheduled for removal in PMD 8.0.0) in favour of `TypeParameterNamingConventions`, which enforces the same single uppercase-letter convention for type parameters by default. The `pmdMain` task printed a deprecation warning for the rule; switching to the successor clears it. https://claude.ai/code/session_014TVLouXfDWCg1sTQVW3ssM
… tests Gradle deprecated the eager `TaskContainer.create(String): Task` overload, so `compileTestKotlin` warned on the task fixtures in `GradleTaskTest` and `TaskDependenciesSpec`. Build each fixture with `project.tasks.register(name).get()`; `.get()` realises the provider to the `Task` the assertions need, with no behaviour change. https://claude.ai/code/session_014TVLouXfDWCg1sTQVW3ssM
…uDPvy Address build deprecation warnings: PMD ruleset and test task creation
alexander-yevsyukov
marked this pull request as ready for review
June 8, 2026 15:55
alexander-yevsyukov
enabled auto-merge
June 8, 2026 15:55
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #178 +/- ##
=========================================
Coverage 90.17% 90.17%
Complexity 552 552
=========================================
Files 122 122
Lines 2230 2230
Branches 311 311
=========================================
Hits 2011 2011
Misses 96 96
Partials 123 123 🚀 New features to boost your workflow:
|
armiol
approved these changes
Jun 8, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the repository to eliminate build-time deprecation warnings by modernizing PMD configuration and switching Gradle test fixtures away from deprecated eager task creation APIs, alongside regenerating versioned dependency-report artifacts.
Changes:
- Replace deprecated PMD rule
GenericsNamingwithTypeParameterNamingConventionsand bump copyright year. - Update Gradle test fixtures to use
tasks.register(name).get()instead of deprecatedtasks.create(name). - Bump snapshot version references and refresh generated dependency-report outputs.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| version.gradle.kts | Bumps versionToPublish snapshot. |
| psi-java/src/test/kotlin/io/spine/tools/psi/PsiElementExtsSpec.kt | Simplifies PSI load helper by removing an unnecessary cast. |
| plugin-base/src/test/kotlin/io/spine/tools/gradle/task/TaskDependenciesSpec.kt | Replaces deprecated eager task creation with lazy registration in tests. |
| plugin-base/src/test/kotlin/io/spine/tools/gradle/task/GradleTaskTest.kt | Replaces deprecated eager task creation with lazy registration in tests. |
| docs/dependencies/pom.xml | Updates generated POM version and adjusts generated first-level dependency list. |
| docs/dependencies/dependencies.md | Refreshes generated dependency report content for the new snapshot. |
| buildSrc/src/main/kotlin/io/spine/dependency/local/Base.kt | Updates buildSrc-managed dependency version constants. |
| buildSrc/quality/pmd.xml | Updates PMD ruleset to avoid a deprecated rule. |
Comment on lines
49
to
53
| * to a member of `PsiFile`. | ||
| */ | ||
| private fun loadClass(tempDir: Path) = | ||
| (FileSystem.load(tempDir.resolve("Stub.java").apply { | ||
| FileSystem.load(tempDir.resolve("Stub.java").apply { | ||
| writeText("class Stub {}") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clears the two classes of deprecation warning surfaced when building
tool-base.PMD settings
pmdMainwarned thatcategory/java/codestyle.xml/GenericsNamingis deprecated (since PMD 7.17.0) and scheduled for removal in PMD 8.0.0:Replaced it with its official successor
TypeParameterNamingConventions, which enforces the same single-uppercase-letter convention for type parameters by default. Copyright year bumped to 2026.Test code
compileTestKotlinwarned on the eager, deprecatedTaskContainer.create(String): TaskinGradleTaskTestandTaskDependenciesSpec:Switched all six task fixtures to the lazy
project.tasks.register(name).get()..get()realises the provider to theTaskthe assertions need — no behaviour change.Generated by Claude Code