Confirm (validate) nested-message behavior is already covered; no code change required - #298
Closed
alexander-yevsyukov with Copilot wants to merge 1 commit into
Closed
Confirm (validate) nested-message behavior is already covered; no code change required#298alexander-yevsyukov with Copilot wants to merge 1 commit into
(validate) nested-message behavior is already covered; no code change required#298alexander-yevsyukov with Copilot wants to merge 1 commit into
Conversation
Copilot
AI
changed the title
[WIP] Fix issue with nested message validation
Confirm May 13, 2026
(validate) nested-message behavior is already covered; no code change required
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This issue asked whether
(validate) = truestill generates nested message validation calls, specifically for enclosed message fields. Current implementation already performs nestedvalidate(...)invocation, and test coverage already exercises this path across singular, repeated, map, andAny-wrapped messages.What was verified
(validate)generation for message fields invokes nested validation rather than relying on callers to manually validate nested targets.Existing coverage that addresses the issue
tests/validating/.../ValidateITest.kt— singular/repeated/map +Anynested validation cases.tests/consumer/.../ValidateRuleITest.kt— consumer-level(validate)rule behavior for enclosed messages.tests/runtime/.../EnclosedMessageValidationSpec.kt— runtime enclosed-message validation semantics.Code path confirmed
java/.../option/ValidateGenerator.ktalready emits nested validation calls:No source or test modifications were necessary in this PR.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
www.jetbrains.com/usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.lang.invoke=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED --add-opens=java.base/java.nio.charset=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.base/java.util.concurrent=ALL-UNNAMED --add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED --add-opens=java.xml/javax.xml.namespace=ALL-UNNAMED --add-opens=java.base/java.time=ALL-UNNAMED -XX:MaxMetaspaceSize=1024m -XX:+UseParallelGC -Xmx4096m -Dfile.encoding=UTF-8 -Duser.country -Duser.language=en -Duser.variant(dns block)If you need me to access, download, or install something from one of these locations, you can either: