Skip to content

Fix ID3 parsing from 64bit file offset (DSF and DFF). #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kimmot wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix ID3 parsing from 64bit file offset (DSF and DFF). #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions include/id3.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ typedef struct id3info {
uint8_t tag_data_safe;
uint32_t size;
uint32_t size_remain;
uint32_t offset; // For non-MP3, offset into file where tag begins
off_t offset; // For non-MP3, offset into file where tag begins
} id3info;

typedef struct id3_compat {
Expand All @@ -117,7 +117,7 @@ extern struct id3_frametype const id3_frametype_experimental;
extern struct id3_frametype const id3_frametype_unknown;
extern struct id3_frametype const id3_frametype_obsolete;

int parse_id3(PerlIO *infile, char *file, HV *info, HV *tags, uint32_t seek, off_t file_size);
int parse_id3(PerlIO *infile, char *file, HV *info, HV *tags, off_t seek, off_t file_size);
int _id3_parse_v1(id3info *id3);
int _id3_parse_v2(id3info *id3);
int _id3_parse_v2_frame(id3info *id3);
Expand Down
2 changes: 1 addition & 1 deletion src/id3.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ _varint(unsigned char *buf, int length)
}

int
parse_id3(PerlIO *infile, char *file, HV *info, HV *tags, uint32_t seek, off_t file_size)
parse_id3(PerlIO *infile, char *file, HV *info, HV *tags, off_t seek, off_t file_size)
{
int err = 0;
unsigned char *bptr;
Expand Down