minichain ascii art#105
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe CLI help banner, prompt, balance output, and send messages were updated to use ANSI color styling. The help text now uses a logo-based layout, and command output includes colored tags and status messages. ChangesCLI ANSI styling updates
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested labels
Poem
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@main.py`:
- Line 358: The transaction rejection message in the CLI is too specific because
the surrounding flow only has a boolean result from mempool.add_transaction(tx),
so it cannot know the actual cause. Update the rejection branch in the
transaction submission path (the print call near the mempool transaction add
result) to use a generic failure message like the RPC path does, and remove the
invented պատճառ labels such as invalid signature, duplicate, or mempool full
unless real error details are available.
- Line 301: The cli_loop coroutine is becoming too large and is mixing command
parsing, rendering, and networking logic; split it up before adding more
behavior. Refactor cli_loop into smaller per-command handler functions or a
dispatch table, and move the new rendering logic out of the main loop so each
command path is handled in a dedicated helper while cli_loop only routes inputs.
- Line 309: The prompt string passed through input in the shell input flow uses
raw ANSI color escapes, which readline counts as printable text and can misalign
wrapped cursors. Update the input prompt in the run_in_executor lambda to wrap
the color sequences used by the minichain prompt with readline non-printing
markers (\001 and \002), keeping the visible prompt text the same while ensuring
the prompt-length calculation ignores the escape codes.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
| """ | ||
|
|
||
|
|
||
| async def cli_loop(sk, pk, chain, mempool, network): |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🔵 Trivial | 🏗️ Heavy lift
Split cli_loop before adding more CLI behavior.
Line 301 is already at 41 branches / 130 statements, and this PR adds more rendering logic into the same coroutine. Extract per-command handlers (or a dispatch table) so future CLI changes stop piling presentation, parsing, and networking into one hot spot.
🧰 Tools
🪛 Ruff (0.15.18)
[warning] 301-301: Too many branches (41 > 12)
(PLR0912)
[warning] 301-301: Too many statements (130 > 50)
(PLR0915)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@main.py` at line 301, The cli_loop coroutine is becoming too large and is
mixing command parsing, rendering, and networking logic; split it up before
adding more behavior. Refactor cli_loop into smaller per-command handler
functions or a dispatch table, and move the new rendering logic out of the main
loop so each command path is handled in a dedicated helper while cli_loop only
routes inputs.
Source: Linters/SAST tools
| while True: | ||
| try: | ||
| raw = await loop.run_in_executor(None, lambda: input("minichain> ")) | ||
| raw = await loop.run_in_executor(None, lambda: input(f"{C_CYAN}minichain>{C_RESET} ")) |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor
🧩 Analysis chain
🏁 Script executed:
python3 - <<'PY'
import sys
import time
# Simulate the environment check
# We cannot run interactive input in this sandbox, but we can verify the logic
# regarding readline and ANSI escape sequences.
# In Python, if you pass a string with ANSI codes to input(), and the target shell
# uses the GNU readline library (standard on Linux/macOS for bash/zsh),
# the prompt length is calculated based on the raw byte count unless non-printing
# characters are marked.
# The standard markers are \001 (start non-printing) and \002 (end non-printing).
# Without these, terminal cursor positioning logic (specifically in readline)
# miscalculates the prompt width, leading to visual glitches on line wrap.
# Test: Check if readline is available and the standard workaround.
try:
import readline
print("GNU Readline is available in this Python build.")
print("Behavior: Raw ANSI in input() prompt causes cursor drift on wrap.")
print("Fix: Wrap non-printing sequences with \\001 and \\002.")
except ImportError:
print("Readline not found. Defaulting to raw input behavior.")
print("\nVerification Conclusion:")
print("The claim is correct. In environments using GNU Readline (default for interactive Python shells),")
print("ANSI color codes passed directly to input() without \\001/\\002 wrappers cause cursor misalignment.")
print("The suggested fix using escaped markers is the standard solution.")
PYRepository: StabilityNexus/MiniChain
Length of output: 617
Wrap the ANSI prompt escapes for readline.
Raw color escapes inside input(...) cause cursor misalignment when the line wraps in readline-enabled terminals (default on Linux/macOS). The shell calculates prompt length by counting raw bytes unless non-printing sequences are explicitly marked.
Use \001 (start) and \002 (end) to bracket the color codes so readline ignores them during width calculation:
- raw = await loop.run_in_executor(None, lambda: input(f"{C_CYAN}minichain>{C_RESET} "))
+ raw = await loop.run_in_executor(None, lambda: input(f"\001{C_CYAN}\002minichain>\001{C_RESET}\002 "))📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| raw = await loop.run_in_executor(None, lambda: input(f"{C_CYAN}minichain>{C_RESET} ")) | |
| raw = await loop.run_in_executor(None, lambda: input(f"\001{C_CYAN}\002minichain>\001{C_RESET}\002 ")) |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@main.py` at line 309, The prompt string passed through input in the shell
input flow uses raw ANSI color escapes, which readline counts as printable text
and can misalign wrapped cursors. Update the input prompt in the run_in_executor
lambda to wrap the color sequences used by the minichain prompt with readline
non-printing markers (\001 and \002), keeping the visible prompt text the same
while ensuring the prompt-length calculation ignores the escape codes.
| print(f" {C_GREEN}✅ Tx sent:{C_RESET} {amount} coins → {receiver[:12]}...") | ||
| else: | ||
| print(" ❌ Transaction rejected (invalid sig, duplicate, or mempool full).") | ||
| print(f" {C_RED}❌ Transaction rejected{C_RESET} (invalid sig, duplicate, or mempool full).") |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Keep the rejection message generic unless you have the actual reason.
mempool.add_transaction(tx) only gives a boolean here, so invalid sig, duplicate, or mempool full can easily be wrong. The RPC path keeps this failure generic for the same reason, so the CLI should avoid inventing causes too.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@main.py` at line 358, The transaction rejection message in the CLI is too
specific because the surrounding flow only has a boolean result from
mempool.add_transaction(tx), so it cannot know the actual cause. Update the
rejection branch in the transaction submission path (the print call near the
mempool transaction add result) to use a generic failure message like the RPC
path does, and remove the invented պատճառ labels such as invalid signature,
duplicate, or mempool full unless real error details are available.
Zahnentferner
left a comment
Zahnentferner
left a comment
There was a problem hiding this comment.
It looks very nice!
I only have a minor suggestion: make the right border of the blue rectangle aligned with the end of the MiniChain word.
2 participants
Addressed Issues:
add minichain heading ASCII
Screenshot arts/Recordings:
Additional Notes:
AI Usage Disclosure:
We encourage contributors to use AI tools responsibly when creating Pull Requests. While AI can be a valuable aid, it is essential to ensure that your contributions meet the task requirements, build successfully, include relevant tests, and pass all linters. Submissions that do not meet these standards may be closed without warning to maintain the quality and integrity of the project. Please take the time to understand the changes you are proposing and their impact. AI slop is strongly discouraged and may lead to banning and blocking. Do not spam our repos with AI slop.
Check one of the checkboxes below:
I have used the following AI models and tools: TODO
Checklist
Summary by CodeRabbit
New Features
Enhancements
balanceoutput readability by colorizing address, balance, and nonce fields and highlighting tags like “(you)” and contract entries.sendcommand terminal feedback with clearer colored success/failure messaging.Bug Fixes
send, including invalid signature/duplicate/mempool-full scenarios.